Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Error pages improvements #16248

Closed
Mugurell opened this issue Oct 29, 2020 · 2 comments
Closed

[Bug] Error pages improvements #16248

Mugurell opened this issue Oct 29, 2020 · 2 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Oct 29, 2020 •
edited by data-sync-user

Following https://bugzilla.mozilla.org/show_bug.cgi?id=1658276 we should look for potential improvements.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. hershey labels Oct 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 29, 2020
@Mugurell Mugurell removed the needs:triage Issue needs triage label Oct 29, 2020
Mugurell added a commit that referenced this issue Dec 4, 2020
@Mugurell
For #16248 - Cleanup error pages of inlined code (#16834)
c89a719 
Also streamlined the js code.
The errorPageScripts.js from AC had too much or too little of what we needed.
@Mugurell Mugurell added the eng:qa:needed QA Needed label Dec 4, 2020
@Mugurell
Copy link
Contributor Author

Mugurell commented Dec 4, 2020

For validating this changes we would just need to know that everything works as before - it looks the same, the buttons work the same.
These error pages can be seen when accessing https://badssl.com/

Please note that for some specific webpages with broken ssl the "Accept the Risk and Continue" button may not work. Pre-existing issue tracked in mozilla-mobile/android-components#9136

@sflorean
Copy link
Contributor

Verified as fixed on Nightly 12/9 with Pixel 3 (Android 11) an Nexus 6(Android 7.1.1).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 10, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@Mugurell @pkirakosyan
For mozilla-mobile#16248 - Cleanup error pages of inlined code (mozil…
0bcf870 
…la-mobile#16834)

Also streamlined the js code.
The errorPageScripts.js from AC had too much or too little of what we needed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mugurell @sflorean