Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Introduce a build flag for Mozilla Online #16256

Closed
st3fan opened this issue Oct 29, 2020 · 0 comments
Closed

Introduce a build flag for Mozilla Online #16256

st3fan opened this issue Oct 29, 2020 · 0 comments
Assignees
@pocmo
Labels
Feature:China
Projects
A-C: Android Components Sprint Planning Fenix in China

Comments

@st3fan
Copy link
Contributor

st3fan commented Oct 29, 2020 •
edited by data-sync-user

Introduce a build flag for Mozilla Online. This can be used in code to conditionally make decisions specifically for Mozilla Online builds.

If a flag is not adequate for the Mozilla Online needs then later on we can add variants.

Let's name the flag 'Mozilla Online'. Or if it a key/value pair, something like Distribution: Mozilla Online? (I don't know how that translates to gradle & code . But I am thinking in the future we may have more distribution specific changes.)

┆Issue is synchronized with this Jira Task
@st3fan st3fan added 🐞 bug Crashes, Something isn't working, .. Feature:China and removed 🐞 bug Crashes, Something isn't working, .. labels Oct 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 29, 2020
@st3fan st3fan removed the needs:triage Issue needs triage label Oct 29, 2020
@pocmo pocmo self-assigned this Oct 29, 2020
@st3fan st3fan added this to In progress in Fenix in China Oct 29, 2020
@pocmo pocmo added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Nov 2, 2020
pocmo added a commit to pocmo/fenix that referenced this issue Nov 2, 2020
@pocmo
Closes mozilla-mobile#16256: Introduce build flag for "Mozilla Online…
c0a349e 
…" variant.

This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).

At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
@pocmo pocmo moved this from 🏃‍♀️ In Progress to ⏳ Review/QA in A-C: Android Components Sprint Planning Nov 2, 2020
@pocmo pocmo closed this as completed in baaa85d Nov 3, 2020
A-C: Android Components Sprint Planning automation moved this from ⏳ Review/QA to 🏁 Done Nov 3, 2020
@pocmo pocmo moved this from In progress to Done in Fenix in China Nov 3, 2020
@st3fan st3fan mentioned this issue Nov 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
Feature:China
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Fenix in China
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@st3fan @pocmo