Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] Consider increasing the text contrast ratio on "Recently closed tabs" from History #16396

Closed
lobontiumira opened this issue Nov 5, 2020 · 5 comments
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. Feature:History good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist wontfix

Comments

@lobontiumira
Copy link

lobontiumira commented Nov 5, 2020

Steps to reproduce

  1. Have the Accessibility scanner app installed and opened.
  2. In Firefox, go to the History page, and scan it.

Expected behavior

No suggestions are made.

Actual behavior

Suggestions are made for the "Recently closed tabs".

  • Text contrast
    org.mozilla.fenix:id/recently_closed_tabs_header
    The item's text contrast ratio is 2.53. This ratio is based on an estimated foreground color of #A29CAE and an estimated background color of #F9F9FB. Consider using colors that result in a contrast ratio greater than 4.50 for small text, or 3.00 for large text. This item may be only partially visible within a scrollable container.

  • Text contrast
    org.mozilla.fenix:id/recently_closed_tabs_description
    The item's text contrast ratio is 1.67. This ratio is based on an estimated foreground color of #C3C3C5 and an estimated background color of #F9F9FB. Consider using colors that result in a contrast ratio greater than 4.50 for small text, or 3.00 for large text. This item may be only partially visible within a scrollable container.

Device information

  • Android device: Google Pixel (Android 10)
  • Fenix version: 11/4 Nightly

┆Issue is synchronized with this Jira Task

@lobontiumira lobontiumira added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:History S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Nov 5, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 5, 2020
@lobontiumira lobontiumira removed the needs:triage Issue needs triage label Nov 5, 2020
@Amejia481 Amejia481 added good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. labels Nov 5, 2020
@topotropic
Copy link

Should use the same color values as the history entries below. Thanks!

@shahsurajk
Copy link
Contributor

Can work on this, are we going ahead with the color palette of the history entries?

fevziomurtekin added a commit to fevziomurtekin/fenix that referenced this issue Jan 23, 2021
fevziomurtekin added a commit to fevziomurtekin/fenix that referenced this issue Jan 23, 2021
@fevziomurtekin
Copy link
Contributor

fevziomurtekin commented Jan 23, 2021

Sorry to send two commits. You can see the changes made in PR.

@lobontiumira
Copy link
Author

Hi all!
This is still reproducible on Beta 87.0.0-beta.2 with OnePlus 5T (Android 10).
These suggestions are made only when at least one of the history entry is selected.

  • light theme:
    light

  • dark theme:
    dark

@stale
Copy link

stale bot commented Aug 30, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 30, 2021
@stale stale bot closed this as completed Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. Feature:History good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist wontfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants