Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Downloads UX updates #16541

Closed
apbitner opened this issue Nov 12, 2020 · 3 comments
Closed

Downloads UX updates #16541

apbitner opened this issue Nov 12, 2020 · 3 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download

Comments

@apbitner
Copy link

apbitner commented Nov 12, 2020

Based on some technical constraints that were encountered in the development of deletion functionality for downloads, UX recommends the following changes:

  • Each file should have the trash icon shown on the right. Tapping on the icon will remove the file from the downloads list, however, the actual file won't be deleted due to technical constraints.
  • In multi-select mode, the 3-dot icon should be shown on the right of the toolbar. It will have two options: Select all and Remove
  • The Delete downloads button can be removed as it is no longer needed.
  • Change the snackbar copy shown after removing a file to Removed [filename]
  • Change the empty state copy to No downloaded files

All changes are reflected in Abstract: https://share.goabstract.com/a0ca3665-5556-4995-b1af-b2fb841a4b6a

┆Issue is synchronized with this Jira Task

@Amejia481
Copy link
Contributor

Each file should have the trash icon shown on the right. Tapping on the icon will remove the file from the downloads list, however, the actual file won't be deleted due to technical constraints.

This also follow the same pattern as what we are doing on Firefox desktop, and what other browsers are doing 👍🏽 .

kglazko pushed a commit to kglazko/fenix that referenced this issue Dec 2, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Dec 2, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Dec 7, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Dec 7, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Dec 8, 2020
kglazko pushed a commit that referenced this issue Dec 8, 2020
@kglazko kglazko added the eng:qa:needed QA Needed label Dec 9, 2020
@lobontiumira
Copy link

Verified as fixed on the 12/14 Nightly build with Samsung Galaxy Tab S6 (Android 10), Sony Xperia Z5 Premium (Android 7.1.1), and OnePlus 5T (Android 9):

  • each downloaded file has a trash icon displayed on the right,
  • tapping on the icon removes the file from the downloads list,
  • in multi-select mode, the 3-dot icon is displayed on the right of the toolbar. It has two options: "Select all" and "Remove".
  • the "Delete downloads" button is no longer displayed,
  • the snackbar copy shown after removing a file is "Removed [filename]",
  • the empty state displays "No downloaded files".
    downloads

@yump
Copy link

yump commented Jan 11, 2021

How about an 🗙 instead of a trash icon? Trash icon still seems to imply that the actual file will be "trashed".

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Download
Projects
None yet
Development

No branches or pull requests

6 participants