Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Enable R8 Full Mode to Maximize Performance Optimizations #1661

Closed
colintheshots opened this issue Apr 16, 2019 · 1 comment
Closed

Enable R8 Full Mode to Maximize Performance Optimizations #1661

colintheshots opened this issue Apr 16, 2019 · 1 comment
Labels
P2 Upcoming release performance Possible performance wins

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Apr 16, 2019 •
edited by data-sync-user

Why/User Benefit/User Problem

As a user, I would like Fenix to be as fast and as small a download size as possible. Enabling the "Full Mode" of Google's R8 optimizer would allow us to achieve additional performance gains relatively cheaply at some cost of QA time and developer fixes.

What / Requirements

Enabling R8 full mode is as simple as a single-line Gradle change. However, it is likely to crash the app at times due to incompatibilities between the legacy ProGuard rules and the new R8 rule set. We need to enable new rules as best we can, test thoroughly to identify issues, and then resolve issues found by adding more new, R8 rules.

Finally, we need a full QA pass after development is done.

Acceptance Criteria (how do I know when I’m done?)

  • The app is running without noticeable crashes after enabling R8 full mode.
  • APK size will be smaller.
  • Some operations will be faster. Measure cold start and page load performance.

┆Issue is synchronized with this Jira Task
@colintheshots colintheshots added the performance Possible performance wins label Apr 16, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 16, 2019
@vesta0 vesta0 added the P2 Upcoming release label Apr 16, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Apr 19, 2019
@colintheshots
For mozilla-mobile#1661: Enable R8 Full Mode to Maximize Perf Optimiz…
aed2fe5 
…ations
colintheshots added a commit that referenced this issue Apr 19, 2019
@colintheshots
For #1661: Enable R8 Full Mode to Maximize Perf Optimizations
cef6c11
@bifleming bifleming modified the milestones: MVP Backlog, Dev Stories Backlog May 2, 2019
@colintheshots
Copy link
Contributor Author

This should be complete and merged into master. We can verify if any issues occur and add rules.

@mcomella mcomella mentioned this issue Dec 17, 2019
Closed
@data-sync-user data-sync-user changed the title Enable R8 Full Mode to Maximize Performance Optimizations FNX2-17302 ⁃ Enable R8 Full Mode to Maximize Performance Optimizations Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17302 ⁃ Enable R8 Full Mode to Maximize Performance Optimizations FNX3-15719 ⁃ Enable R8 Full Mode to Maximize Performance Optimizations Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15719 ⁃ Enable R8 Full Mode to Maximize Performance Optimizations FNX-5166 ⁃ Enable R8 Full Mode to Maximize Performance Optimizations Aug 11, 2020
ebraminio added a commit to persian-calendar/persian-calendar that referenced this issue May 1, 2021
@ebraminio
Enable R8 full mode
3fb01b5 
Enabled by mozilla-mobile/fenix#1661
so we can also proceed with it, just that we should test it to see
if we don't break anything.
@data-sync-user data-sync-user changed the title FNX-5166 ⁃ Enable R8 Full Mode to Maximize Performance Optimizations Enable R8 Full Mode to Maximize Performance Optimizations May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 Upcoming release performance Possible performance wins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@colintheshots @vesta0 @bifleming @data-sync-user