Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Different behavior for "Sign in to sync" button in list & grid view after deselecting tabs #16614

Closed
sflorean opened this issue Nov 17, 2020 · 1 comment
Closed

[Bug]Different behavior for "Sign in to sync" button in list & grid view after deselecting tabs #16614

sflorean opened this issue Nov 17, 2020 · 1 comment
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SyncTabs Sync tabs Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sflorean
Copy link
Contributor

sflorean commented Nov 17, 2020 •
edited by data-sync-user

Steps to reproduce 1

  1. Open 2-3 tabs in list view.
  2. Open tabs tray and tap on "Select tabs".
  3. Select 1- tabs.
  4. Tap on "x" from the selection menu.
  5. Check "Sign in to sync" button.

Expected behavior

The following is displayed in this order:

  • Open tabs
  • "Select tabs" button
  • "Sign in to sync" button

Actual behavior

The following is displayed in this order:

  • "Sign in to sync" button
  • Open tabs
  • "Select tabs" button

Steps to reproduce 2

  1. Open 2-3 tabs in grid view.
  2. Open tabs tray and tap on "Select tabs".
  3. Select 1- tabs.
  4. Tap on "x" from the selection menu.
  5. Close and reopen Fenix and open Tabs tray.
  6. Check "Sign in to sync" button.

Expected behavior

The following is displayed in this order:

  • Open tabs
  • "Select tabs" button
  • "Sign in to sync" button

Actual behavior

The following is displayed in this order:

  • Open tabs
  • "Sign in to sync" button
  • "Select tabs" button

Device information

  • Android device: Pixel 3 (Android 11)
  • Fenix version: Nightly 11/17

┆Issue is synchronized with this Jira Task
@sflorean sflorean added the 🐞 bug Crashes, Something isn't working, .. label Nov 17, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 17, 2020
@sflorean sflorean mentioned this issue Nov 17, 2020
Closed
@sflorean sflorean added Feature:SyncTabs Sync tabs Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels Nov 17, 2020
@Mugurell Mugurell self-assigned this Nov 17, 2020
gabrielluong pushed a commit that referenced this issue Nov 17, 2020
@Mugurell
For #16614 - Ensure a stable order for the items in tabs tray. (#16618)
ef5846d 
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items

This order should also be kept after returning from Multiselect mode.
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Nov 17, 2020
@gabrielluong gabrielluong added this to Inbox in Engineering triage via automation Nov 17, 2020
@gabrielluong gabrielluong moved this from Inbox to Grid View in Engineering triage Nov 17, 2020
@sflorean
Copy link
Contributor Author

Verified as fixed on Nightly 11/18 with Pixel 3 (Android 11).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 18, 2020
@gabrielluong gabrielluong removed this from Grid View in Engineering triage Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SyncTabs Sync tabs Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrielluong @Mugurell @sflorean