Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The buttons from Connect another device -> Send to device are joined together #16675

Closed
ebalazs-sv opened this issue Nov 20, 2020 · 1 comment
Closed

[Bug] The buttons from Connect another device -> Send to device are joined together #16675

ebalazs-sv opened this issue Nov 20, 2020 · 1 comment
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SyncTabs Sync tabs S3 Blocks non-critical functionality and a work around exists

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Nov 20, 2020 •
edited by data-sync-user
Loading

Make sure you are logged in on a single mobile device.

Steps to reproduce

  1. Open a tab, tap "Share" from the three-dot menu.
  2. Tap the "Connect another device" button from "Send to device" section.
  3. Observe the "Send to device" buttons.

Expected behavior

There are two separate buttons: "Learn About Sending Tabs..." and "Connect Another Device..."
rsz_screenshot_20201120-131801_firefox

Actual behavior

The buttons from Connect another device -> Send to device are joined together, but when tapped, they work as expected.
rsz_1rsz_screenshot_20201120-123241_firefox_beta

Device information

  • Android device: Samsung Galaxy Tab S3 (Android 8)
  • Fenix version: Beta 84.0.0-beta.1 from 11/18, Nightly 11/20
    Not reproducible on Release 83.1.0 from 11/18

┆Issue is synchronized with this Jira Task
@ebalazs-sv ebalazs-sv added the 🐞 bug Crashes, Something isn't working, .. label Nov 20, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 20, 2020
@ebalazs-sv ebalazs-sv added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist S3 Blocks non-critical functionality and a work around exists Feature:SyncTabs Sync tabs and removed S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Nov 20, 2020
@AndiAJ AndiAJ removed the needs:triage Issue needs triage label Nov 20, 2020
@ekager ekager self-assigned this Nov 21, 2020
ekager added a commit to ekager/fenix that referenced this issue Nov 21, 2020
@ekager
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
4dbab6a
ekager added a commit to ekager/fenix that referenced this issue Nov 21, 2020
@ekager
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
899126e
ekager added a commit to ekager/fenix that referenced this issue Nov 21, 2020
@ekager
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
344fdd8
ekager added a commit to ekager/fenix that referenced this issue Nov 30, 2020
@ekager
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
ba0e600
ekager added a commit to ekager/fenix that referenced this issue Dec 4, 2020
@ekager
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
a842cb5
ekager added a commit to ekager/fenix that referenced this issue Dec 11, 2020
@ekager
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
43a41b3
ekager added a commit that referenced this issue Dec 11, 2020
@ekager
For #16675 For #16398 - Fix button styling
2796a7f
@ekager ekager added the eng:qa:needed QA Needed label Dec 11, 2020
@ebalazs-sv
Copy link
Author

Verified as fixed on Nightly 201214 05:03 (Build #2015781291) GV 85 from 12/14 with Samsung Galaxy Tab S3 (Android 8) and Pixel 2 (Android 9).
I will close the issue and remove the qa:needed label for now.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 14, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@ekager @pkirakosyan
For mozilla-mobile#16675 For mozilla-mobile#16398 - Fix button styling
b941500
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SyncTabs Sync tabs S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ekager @ebalazs-sv @AndiAJ