Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Allow autoplay to controlled via the toolbar #16847

Closed
Amejia481 opened this issue Dec 3, 2020 · 6 comments
Closed

Allow autoplay to controlled via the toolbar #16847

Amejia481 opened this issue Dec 3, 2020 · 6 comments
Assignees
@Amejia481
Labels
eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:SitePermissions
Projects
A-C: Android Components Sprint Planning Android Engineering Team Kanban board
Milestone
86

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Dec 3, 2020 •
edited by data-sync-user
Loading

Related issue #11325

image

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added feature request 🌟 New functionality and improvements Feature:SitePermissions labels Dec 3, 2020
@Amejia481 Amejia481 self-assigned this Dec 3, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 3, 2020
@Amejia481 Amejia481 mentioned this issue Dec 3, 2020
Closed
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Dec 9, 2020
Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 9, 2020
@Amejia481
For issue mozilla-mobile#16847 Show autoplay toolbar icon
417e659
@Amejia481 Amejia481 mentioned this issue Dec 9, 2020
Merged
3 tasks
Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 9, 2020
@Amejia481
For issue mozilla-mobile#16847 Show the autoplay icon in the toolbar
8cc6ece
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Dec 9, 2020
Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 10, 2020
@Amejia481
For issue mozilla-mobile#16847 Show the autoplay icon in the toolbar
5ce3519
Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 11, 2020
@Amejia481
For issue mozilla-mobile#16847 Show the autoplay icon in the toolbar
90b7af5
Amejia481 added a commit that referenced this issue Dec 14, 2020
@Amejia481
For issue #16847 Show the autoplay icon in the toolbar
f263b73
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Dec 14, 2020
@sheikh-azharuddin
Copy link

@Amejia481 quick question bro why there is a blue dot showing in the security lock icon in your screenshot? Are you planning to integrate tracking protection with the lock icon similar to edge?

@Amejia481
Copy link
Contributor Author

@Amejia481 quick question bro why there is a blue dot showing in the security lock icon in your screenshot? Are you planning to integrate tracking protection with the lock icon similar to edge?

Hi @sheikh-azharuddin 👋🏽
The image above was an old mock-up, back them we didn't have a lot of space available as we were showing www. and we were trying to save space by having multiple functions for the same icon, now we have more space available and we can do something similar to what Firefox desktop does, showing the autoplay icon when some content get blocked you can see an example here, I think the initial functionality is already in nightly if you want to give a try. :)

@Dunexus
Copy link

Dunexus commented Dec 15, 2020

Hi @Amejia481
As you said, the autoplay icon has been added in nightly. However, its addition is bringing the issue of visible url width back, see #17047.

@Amejia481
Copy link
Contributor Author

Hi @Amejia481
As you said, the autoplay icon has been added in nightly. However, its addition is bringing the issue of visible url width back, see #17047.

Thanks for reporting I left some comments in the issue #17047 (comment) :)

Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 17, 2020
@Amejia481
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar
9baeb95
Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 17, 2020
@Amejia481
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar
68239c4
Amejia481 added a commit to Amejia481/fenix that referenced this issue Dec 17, 2020
@Amejia481
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar
03e0012
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Review/QA in A-C: Android Components Sprint Planning Dec 17, 2020
Amejia481 added a commit to Amejia481/fenix that referenced this issue Jan 4, 2021
@Amejia481
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar.
d1b5809
Amejia481 added a commit to Amejia481/fenix that referenced this issue Jan 12, 2021
@Amejia481
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar.
0d22c74
pocmo pushed a commit to pocmo/fenix that referenced this issue Jan 13, 2021
@Amejia481 @pocmo
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar.
adbc7f1
pocmo pushed a commit that referenced this issue Jan 13, 2021
@Amejia481 @pocmo
For #16847: Allow autoplay to controlled via the toolbar.
00d971e
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Jan 13, 2021
@Amejia481
Copy link
Contributor Author

This feature is on master now, ready for QA review :)

@Amejia481 Amejia481 added this to Ready for Engineering in Android Engineering Team Kanban board via automation Jan 13, 2021
@Amejia481 Amejia481 moved this from Ready for Engineering to In Testing/QA in Android Engineering Team Kanban board Jan 13, 2021
@Amejia481 Amejia481 removed the needs:triage Issue needs triage label Jan 13, 2021
@abodea
Copy link
Member

abodea commented Jan 14, 2021

Verified as fixed on the latest Nightly 1/14 with Google Pixel 4 XL (11).
Note that the option can be changed without problems and all the buttons are working as expected.
There are 2 new issues regarding this implementation #17464 and #17457.

@abodea abodea closed this as completed Jan 14, 2021
A-C: Android Components Sprint Planning automation moved this from ⏳ Review/QA to 🏁 Done Jan 14, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA (WIP limit - ?) to Done Jan 14, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 14, 2021
@amedyne amedyne added this to the 86 milestone Feb 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@Amejia481 @pkirakosyan
For issue mozilla-mobile#16847 Show the autoplay icon in the toolbar
1651232
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@Amejia481 @pkirakosyan
For mozilla-mobile#16847: Allow autoplay to controlled via the toolbar.
237723c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:SitePermissions
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Android Engineering Team Kanban board
Done
Milestone
86
Development

No branches or pull requests
5 participants
@Amejia481 @Dunexus @abodea @sheikh-azharuddin @amedyne