Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Sync logs off on poor connection #17301

Closed
eliserichards opened this issue Jan 4, 2021 · 2 comments
Closed

[Bug] Sync logs off on poor connection #17301

eliserichards opened this issue Jan 4, 2021 · 2 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Accounts Feature:Sync pin Issues, features, improvements that are still valid

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Jan 4, 2021

https://bugzilla.mozilla.org/show_bug.cgi?id=1684346

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:86.0) Gecko/86.0 Firefox/86.0
Firefox for Android

Steps to reproduce:

My phone suffers from poor connectivity. This has not been an issue for Firefox until some recent update. Now sync logs me out randomly throughout the day. Logging back in is difficult under my unreliable connection, and is further hampered since I use 2FA. However, this isn't the issue, the issue is that a bad connection should not result in being permanently logged out but should log one back in on re-establishing the connection even when using 2FA.

Expected results:

Remain logged in after reconnecting.

┆Issue is synchronized with this Jira Task

@eliserichards eliserichards added 🐞 bug Crashes, Something isn't working, .. Feature:Sync labels Jan 4, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 4, 2021
@eliserichards eliserichards added pin Issues, features, improvements that are still valid and removed needs:triage Issue needs triage labels Jan 4, 2021
@grigoryk
Copy link
Contributor

grigoryk commented Jan 4, 2021

A poor connection would case network errors to be more likely. Sounds like we may erroneously end-up in a logged-out state as a result of some network operation failing - likely during startup when we initialize the account.

For some context, as of mozilla-mobile/android-components#7856 error transitions became more explicit, and in PRs like mozilla-mobile/android-components#8498 we've been various "network error causes problems" problems. Perhaps 7856 is the reason why user reports this as a "recent" regression.

@jonalmeida
Copy link
Contributor

Re-opened back in bugzilla as part of issue migration: https://bugzilla.mozilla.org/show_bug.cgi?id=1684346

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Accounts Feature:Sync pin Issues, features, improvements that are still valid
Projects
None yet
Development

No branches or pull requests

3 participants