This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #8492: Gracefully handle network failures while obtaining token server url #8498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grigoryk
force-pushed
the
issue8492TokenserverNetwork
branch
from
ba7ab49
to
2eedbf0
Compare
grigoryk
force-pushed
the
issue8492TokenserverNetwork
branch
from
2eedbf0
to
133401d
Compare
grigoryk
force-pushed
the
issue8492TokenserverNetwork
branch
from
133401d
to
d484fb2
Compare
csadilek
approved these changes
Sep 25, 2020
| @@ -184,8 +184,10 @@ class FirefoxAccount internal constructor( | |||
| } | |||
| } | |||
|
|
|||
| override fun getTokenServerEndpointURL(): String { | |||
| return inner.getTokenServerEndpointURL() | |||
| override suspend fun getTokenServerEndpointURL() = withContext(scope.coroutineContext) { | |||
There was a problem hiding this comment.
Curious how this didn't fail before? Was it wrapped in an handleFxaExceptions and we lost that? Or are we calling it more often now?
There was a problem hiding this comment.
Still investigating this. It's neither of those, I'll let you know once I sort this out. Maybe it was failing and we didn't notice, somehow..?
|
RE metrics - yup, these doc files keep getting out of date, somehow, I commit these diffs when I see them locally. Quite annoying. |
grigoryk
added
🛬 needs landing
added 2 commits
September 25, 2020 11:37
…obtaining token server url
grigoryk
force-pushed
the
issue8492TokenserverNetwork
branch
from
d484fb2
to
a9bcd73
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge