Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Icon to delete browsing history in Private Browsing address bar #1751

Closed
brampitoyo opened this issue Apr 18, 2019 · 6 comments
Closed

Icon to delete browsing history in Private Browsing address bar #1751

brampitoyo opened this issue Apr 18, 2019 · 6 comments
Assignees
@brampitoyo @ekager
Labels
Feature:PrivateBrowsing
Projects
Fenix MVP UX
Milestone
Sprint 5-1 (Miles...

Comments

@brampitoyo
Copy link

brampitoyo commented Apr 18, 2019 •
edited by data-sync-user
Loading

Our current Private Browsing design includes a link to delete history on the tab view:

We’re going to introduce a way to delete history while you’re browsing privately, by including a garbage bin icon on the left side of the address bar:

https://mozilla.invisionapp.com/share/8CRLVWE2HKY

CC @sblatz @mheubusch and @AmyYLee.

┆Issue is synchronized with this Jira Task
@brampitoyo brampitoyo added this to the MVP Backlog milestone Apr 18, 2019
@brampitoyo brampitoyo added this to Backlog of upcoming work in Fenix MVP UX via automation Apr 18, 2019
@ekager ekager self-assigned this Apr 18, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 18, 2019
@ekager
For mozilla-mobile#1751 - Add Delete Button to Private Toolbar
ca53cf4
ekager added a commit that referenced this issue Apr 18, 2019
@ekager
For #1751 - Add Delete Button to Private Toolbar
c8061bd
@cadeyrn cadeyrn mentioned this issue Apr 18, 2019
Closed
@mheubusch
Copy link
Contributor

mheubusch commented Apr 22, 2019 •
edited
Loading

@brampitoyo can you address 1788 to unblock this? if it is no longer relevant due to new designs you can close it too.

@vesta0 vesta0 added the P1 Current sprint label Apr 24, 2019
@vesta0 vesta0 added this to In Progress in Fenix Sprint Kanban Apr 24, 2019
@sblatz sblatz added the eng:qa:needed QA Needed label Apr 25, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban Apr 25, 2019
@kbrosnan kbrosnan added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 26, 2019
@project-bot project-bot bot moved this from Ready for QA to Blocked in Fenix Sprint Kanban Apr 26, 2019
@kbrosnan
Copy link
Contributor

@brampitoyo @mheubusch Invision link is dead. I need this to verify the bug.

@sblatz
Copy link
Contributor

sblatz commented Apr 26, 2019

@kbrosnan try this link

@kbrosnan
Copy link
Contributor

@sblatz please make that a share link. I don't have an invision account.

@sblatz
Copy link
Contributor

sblatz commented Apr 26, 2019

@kbrosnan sorry about that! here you go

@brampitoyo
Copy link
Author

brampitoyo commented Apr 29, 2019 •
edited
Loading

@kbrosnan I just returned from PTO. For ease of use, here’s the relevant content of that InVision document as a screenshot

As discussed on #1788 (comment):

@topotropic wrote:

I discussed this with @shorlander and we want to remove the garbage icon.

So this issue is no longer relevant, and needs to be closed.

Fenix MVP UX automation moved this from Backlog of upcoming work to Done Apr 29, 2019
@ghost ghost removed the P1 Current sprint label Apr 29, 2019
ekager added a commit that referenced this issue Apr 29, 2019
@ekager
Revert "For #1751 - Add Delete Button to Private Toolbar"
324d64b 
This reverts commit c8061bd.
@vesta0 vesta0 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 29, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 29, 2019
@ekager
Revert "For mozilla-mobile#1751 - Add Delete Button to Private Toolbar"
e10b4ab 
This reverts commit c8061bd.
ekager added a commit that referenced this issue Apr 29, 2019
@ekager
Revert "For #1751 - Add Delete Button to Private Toolbar"
583889c 
This reverts commit c8061bd.
@ekager ekager moved this from Blocked to Done in Fenix Sprint Kanban May 2, 2019
@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label May 3, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title Icon to delete browsing history in Private Browsing address bar FNX2-17384 ⁃ Icon to delete browsing history in Private Browsing address bar Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17384 ⁃ Icon to delete browsing history in Private Browsing address bar FNX3-15796 ⁃ Icon to delete browsing history in Private Browsing address bar Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15796 ⁃ Icon to delete browsing history in Private Browsing address bar FNX-5228 ⁃ Icon to delete browsing history in Private Browsing address bar Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5228 ⁃ Icon to delete browsing history in Private Browsing address bar Icon to delete browsing history in Private Browsing address bar May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brampitoyo brampitoyo

@ekager ekager

Labels
Feature:PrivateBrowsing
Projects
No open projects
Fenix MVP UX
  
Done
Milestone
Sprint 5-1 (Milestone 5)
Development

No branches or pull requests
8 participants
@brampitoyo @kbrosnan @sv-ohorvath @sblatz @mheubusch @ekager @vesta0 @data-sync-user