Downloads prompts do not show again when a user denies system permission twice

[Amejia481]

If you try to download a file and deny the system dialog permission, and then do it again after that you are never going to get the system permission dialog again and all future downloads are going to be cancel by default without users noticing.

To fix that we have to do something similar to what we did on this pr, we have to use shouldShowRequestPermissionRationale to verify if permissions have been denied permanently and users have to go to the settings page and grant the permission there, for more information see https://developer.android.com/training/permissions/requesting#request-permission

┆Issue is synchronized with this Jira Task

[VitalyVPinchuk]

Hello @Amejia481
Could I try to fix it?

[Amejia481]

Thanks @VitalyVPinchuk for being interested in this issue, I was taking a closer look and I think it could take more work that I'm initially estimate, we prefer to work on the issue, please feel free to take other one, sorry for the inconveniences.

[ebalazs-sv]

This issue is not reproducible on Nightly 3/10, Beta 87.0.0-beta.4 from 3/8 and Release 86.1.1 from 2/23 with the following devices:

• Motorola Moto G6 (Android 8);
• LG G7 Fit (Android 8.1);
• Pixel 2 (Android 9);
• Samsung Note 10 (Android 11).

@Amejia481 Hi! Since the related issue mozilla-mobile/android-components#9812 is not fixed yet, I will move this in development.

[Amejia481]

Nightly 3/1

Thanks for testing, It could be that nightly version doesn't have the fix. Which AC version does it have? The version that have the fixed is ac 74.0.20210308190145

[ebalazs-sv]

The Nightly tested has the AC version 74.0.20210309154120 and I could not reproduce the issue on this build, neither on the latest Beta or Release builds.

[Amejia481]

Did you see the download dialog after denying permissions twice?

[ebalazs-sv]

Did you see the download dialog after denying permissions twice?

Yes, the download dialog is displayed after denying the permissions twice.

[Amejia481]

Sorry for the delay, the fixed is on nightly.

The expected behavior is the dialog is shown when the permission is denied, indicating the user to go the settings page and allow the permission, if the user do so the download dialog will show the next time we try to download a file.

screencapture-1615822262411.mp4

[lobontiumira]

Verified as fixed on the 3/17 Nightly build, using a Google Pixel (Android 10).
After denying the download, the "Files and media permission access needed to download files. Go to Android settings, tap permissions, and tap allow. DISMISS GO TO SETTINGS" propmt is displayed. Tapping on "GO TO SETTINGS" redirects the user to the Android permissions. Tapping on "DISMISS" dismisses the prompt; if trying to download again and denying again, the prompt is displayed again.

[Amejia481]

Thanks @lobontiumira !