[Feature] Request desktop site from new tab menu

[eliserichards]

Meta: #17796
Followup to #17770
UX point of contact: @violasong (Victoria)

Figma designs (bottom right, labeled "Final design"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1

Acceptance criteria

• User flow: Open a new tab, open the three-dot menu, select "Request desktop site"
• This toggle already exists on the main three-dot menu (when a user is already on a site)
• If a user toggles this to ON, when they enter a URL/search they will automatically be brought to the desktop site
• Once the session is started, desktop mode behaves as it normally does now, and any new navigation within that session will request desktop mode until the toggle is turned OFF
• When the user opens a new tab, "Request desktop site" is always OFF (even if they have toggled it ON in a previous session). (See Chrome behavior as an example)

---

┆Issue is synchronized with this Jira Task

[mcarare]

Question: Will the state of the toggle be remembered between multiple new tabs? Or it is used just for the next tab navigation?

[violasong]

It should be used just for the navigation within that tab. Additional new tabs should go back to the default of mobile view.

[mcarare]

So it will be just to load the desktop version without having to load the mobile one? (The same number of steps as requesting desktop version from a tab).

I thought it was related to a feature request: #7039.

[mcarare]

It should be used just for the navigation within that tab. Additional new tabs should go back to the default of mobile view.

In this case, I would need a more detailed description of this feature. What is intended for? Do we use this for topsites also?
When should it reset back to OFF?

[violasong]

I think request #7039 will be important to solve later, but for the purposes of this bug, yes, it's just to load the desktop site without having to load the mobile site. It should work the same way as it currently does, where it doesn't reset back to off for that tab unless the user chooses to toggle it off. Yes, it should work for top sites.

CC: @kbrosnan may be able to help with a more detailed info around this feature, since I believe he gave me the idea originally :).

[mcarare]

Waiting for feedback from @kbrosnan

[eliserichards]

Confirmed with @csadilek that we can move ahead with this implementation without making the home screen a tab.

We need to make sure that we are requesting desktop site on URL load, not loading and then toggling (see gecko engine toggle).

When a user is on a new tab and turns Request Desktop Site ON, it will persist for that session (just like current behavior). If the user opens a new tab again, Request Desktop Site defaults back to OFF. The on/off state of this toggle only needs to be known until the session begins.

I added some more info to the description at the top :)

[lobontiumira]

Verified on the debug build with AC: 75.0.20210405143037, a69f74ece, and GV 89.0a1-20210405094633 on Google Pixel (Android 10), Samsung Galaxy Note 8 (Android 9), and HTC 10 (Android 8):

• when the user toggles the request desktop site from the three-dot main menu, the next page opened is as a desktop site,
• if the user loads a URL or performs a search from the address bar in that previous opened page, desktop site keeps its state,
• opening a new tab/page, does not enable the desktop site toggle,
• if the user taps on links in that previous opened page that leads to a different page, desktop site DOES NOT keep its state,

@eliserichards please review and advise. Should I file a new issue for the behavior mentioned above?

desktop.site.toggle.mp4

[amedyne]

@lobontiumira To clarify for this bullet:

• if the user taps on links in that previous opened page that leads to a different page, desktop site DOES NOT keep its state,

does the new opened page open in a new tab?

[lobontiumira]

@amedyne the new opened page opens in the same tab.

I.e. wikipedia.org, bbc.com respects the desktop site, going in the same tab from link to link, opens all the links as desktop sites (in the same tab).
But, opening getpocket.com as desktop site, tapping on any other link from that page, loads the new page not as a desktop site.

[mcarare]

@lobontiumira When you click on stories from getpocket.com they open in new tabs, not in the same one. So IMO it is expected they are to be loaded in a mobile mode tab.
At the same time, all links that continue navigation in the same site, such as "help", topics from "discover more topics", are navigated to from the same tab and keep the desktop mode.

[eliserichards]

Closing as done :)