Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Improve search telemetry #17956

Closed
st3fan opened this issue Feb 10, 2021 · 0 comments
Closed

Improve search telemetry #17956

st3fan opened this issue Feb 10, 2021 · 0 comments

Comments

@st3fan
Copy link
Contributor

st3fan commented Feb 10, 2021

This was taken from #17637 (review)

At the end of the day this code searches the Google SearchEngine instance only, with the check above. Should we simplify this?

If we want to keep it generic for supporting more search engines in the future then:

  • Should we check resultUrls instead of suggestUrl since the latter one is the URL we query search suggestions from and doesn't have to be related to the search engine URL. The result URLs may be closer.
  • Should we also search in *.state.search.availableEngines? Otherwise you will not find a search engine if the user decided to hide it.
  • In appendSearchAttributionToUrlIfNeeded() we already change the URL to the one with the search attribution, so we already know the context, it seems complicated to then check this here again. 🤔 This would also allow us to directly lookup the search engine (e.g. Google) and not have to search for it here, I assume?

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 10, 2021
@amedyne amedyne added Feature:Search and removed needs:triage Issue needs triage labels Feb 10, 2021
@amedyne amedyne added this to New Features/Functions (top 20) in Android Team Backlog Staging Board Feb 10, 2021
@amedyne amedyne removed this from New Features/Functions (top 20) in Android Team Backlog Staging Board Feb 15, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Feb 15, 2021
@rocketsroger rocketsroger self-assigned this Feb 19, 2021
@rocketsroger rocketsroger moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 19, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 23, 2021
@rocketsroger rocketsroger moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Feb 23, 2021
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Mar 19, 2021
@gabrielluong gabrielluong added this to the 88 milestone Mar 23, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

4 participants