Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add Telemetry When User Opens a Bookmark #18173

Closed
rocketsroger opened this issue Feb 25, 2021 · 1 comment · Fixed by #18174
Closed

Add Telemetry When User Opens a Bookmark #18173

rocketsroger opened this issue Feb 25, 2021 · 1 comment · Fixed by #18174
Assignees
@rocketsroger
Labels
eng:qa:verified QA Verified Feature:Telemetry
Projects
Android Engineering Team Kanban board
Milestone
88

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Feb 25, 2021 •
edited by data-sync-user
Loading

Currently we're not tracking when user is opening a bookmark by tapping directly on the bookmark. Add telemetry to track it.
This is for #14866

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger self-assigned this Feb 25, 2021
@rocketsroger rocketsroger added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Feb 25, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 25, 2021
@rocketsroger rocketsroger moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Feb 25, 2021
@rocketsroger rocketsroger removed the needs:triage Issue needs triage label Feb 25, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Feb 25, 2021
@rocketsroger
Closes mozilla-mobile#18173: Add Telemetry When User Opens a Bookmark
fb36ca4
@rocketsroger rocketsroger mentioned this issue Feb 25, 2021
Merged
3 tasks
@rocketsroger rocketsroger moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Feb 25, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Mar 8, 2021
@rocketsroger
Closes mozilla-mobile#18173: Add Telemetry When User Opens a Bookmark
6f85b54
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Mar 8, 2021
@gabrielluong gabrielluong added this to the 88 milestone Mar 9, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Mar 9, 2021
@gabrielluong gabrielluong reopened this Mar 9, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Mar 9, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to In Testing/QA in Android Engineering Team Kanban board Mar 9, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Mar 12, 2021

Hi, verified as fixed on the latest Nightly 210312 using a Google Pixel 3a (Android 11)
Ping ffbaa16d-5fbd-4aa7-83a5-1b2bb8bc6ebd

"events": [
        {
          "category": "events",
          "extra": {
            "first_frame_pre_draw_nanos": "50786516",
            "source": "UNKNOWN",
            "type": "HOT"
          },
          "name": "app_opened_all_startup",
          "timestamp": 0
        },
        {
          "category": "bookmarks_management",
          "name": "open",
          "timestamp": 8513
        }
      ]

Logcat

@AndiAJ AndiAJ closed this as completed Mar 12, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Mar 12, 2021
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 12, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
@rocketsroger @pkirakosyan
Closes mozilla-mobile#18173: Add Telemetry When User Opens a Bookmark (…
771b70a 
…mozilla-mobile#18174)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
eng:qa:verified QA Verified Feature:Telemetry
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
88
Development

Successfully merging a pull request may close this issue.

Closes #18173: Add Telemetry When User Opens a Bookmark rocketsroger/fenix
3 participants
@gabrielluong @rocketsroger @AndiAJ