Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update tab visual style #1830

Closed
boek opened this issue Apr 19, 2019 · 5 comments
Closed

Update tab visual style #1830

boek opened this issue Apr 19, 2019 · 5 comments
Assignees
@boek
Labels
eng:qa:verified QA Verified Feature:Collections Feature:Tabs P1 Current sprint Release Blocker Blocks a Release
Milestone
Sprint 5-2 (Miles...

Comments

@boek
Copy link
Contributor

boek commented Apr 19, 2019 •
edited by data-sync-user
Loading

image

┆Issue is synchronized with this Jira Task
@boek boek added the 🐞 bug Crashes, Something isn't working, .. label Apr 19, 2019
@boek boek self-assigned this Apr 19, 2019
This was referenced Apr 19, 2019
Closed
Closed
@boek boek removed the 🐞 bug Crashes, Something isn't working, .. label Apr 19, 2019
boek added a commit to boek/fenix that referenced this issue Apr 19, 2019
@boek
For mozilla-mobile#1830 - Updates the tab visual style
e6e5b38
boek added a commit to boek/fenix that referenced this issue Apr 19, 2019
@boek
For mozilla-mobile#1830 - Adds the ability to share a tab
a2408ec
boek added a commit to boek/fenix that referenced this issue Apr 19, 2019
@boek
For mozilla-mobile#1830 - Adds the ability to share a tab
d6b9341
boek added a commit that referenced this issue Apr 19, 2019
@boek
For #1830 - Updates the tab visual style
774c5c0
boek added a commit that referenced this issue Apr 19, 2019
@boek
For #1830 - Adds the ability to share a tab
4ea5425
@vesta0 vesta0 added this to the Sprint 4-2 (Milestone 4) milestone Apr 24, 2019
@vesta0 vesta0 added this to Ready for QA in Fenix Sprint Kanban Apr 24, 2019
@sv-ohorvath
Copy link
Contributor

@boek Are the thumbnail images going to be implemented later or should they already be done? Not appearing at the moment.

@yoasif
Copy link
Contributor

yoasif commented Apr 25, 2019

FWIW, whatever the thumbnail building code exists in Fennec seems to work really well and always seems to look good in my experience. The one in Fenix never seemed to look right to me. Fennec also used squares, so it is something to look at, imo.

@kbrosnan kbrosnan removed the eng:qa:needed QA Needed label Apr 26, 2019
@kbrosnan
Copy link
Contributor

The base of the styles are in product however we are missing the favicons. This is not complete until the spec is met. @boek @st3fan [Jeff is on PTO]

@kbrosnan kbrosnan added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 26, 2019
@project-bot project-bot bot moved this from Ready for QA to Blocked in Fenix Sprint Kanban Apr 26, 2019
@kbrosnan kbrosnan added Feature:Tabs and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Apr 27, 2019
@vesta0 vesta0 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 29, 2019
@vesta0 vesta0 added the P1 Current sprint label May 8, 2019
@sblatz sblatz changed the title Update tab visual styel Update tab visual style May 9, 2019
@vesta0 vesta0 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 14, 2019
@vesta0 vesta0 moved this from Blocked to Ready for Dev in Fenix Sprint Kanban May 14, 2019
@vesta0 vesta0 moved this from Ready for Dev to In Progress in Fenix Sprint Kanban May 14, 2019
@boek boek moved this from In Progress to Blocked in Fenix Sprint Kanban May 15, 2019
@boek boek added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 15, 2019
@bifleming bifleming added the Release Blocker Blocks a Release label May 17, 2019
@vesta0 vesta0 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 18, 2019
@vesta0 vesta0 moved this from Blocked to Ready for Dev in Fenix Sprint Kanban May 18, 2019
@boek boek added the eng:qa:needed QA Needed label May 21, 2019
@project-bot project-bot bot moved this from Ready for Dev to Ready for QA in Fenix Sprint Kanban May 21, 2019
@sv-ohorvath
Copy link
Contributor

@boek This was blocked by the missing thumbnail images. Currently, it's still in the same state. Is there any change we should test?

@sv-ohorvath
Copy link
Contributor

Ok, I just saw the thumbnails being updated, but for some websites it takes a little longer. Marking this as fixed on the 5/22 build.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 22, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 22, 2019
@data-sync-user data-sync-user changed the title Update tab visual style FNX2-17434 ⁃ Update tab visual style Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17434 ⁃ Update tab visual style FNX3-15846 ⁃ Update tab visual style Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15846 ⁃ Update tab visual style FNX-5272 ⁃ Update tab visual style Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5272 ⁃ Update tab visual style Update tab visual style May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boek boek

Labels
eng:qa:verified QA Verified Feature:Collections Feature:Tabs P1 Current sprint Release Blocker Blocks a Release
Projects
None yet
Milestone
Sprint 5-2 (Milestone 5)
Development

No branches or pull requests
7 participants
@yoasif @kbrosnan @boek @sv-ohorvath @vesta0 @bifleming @data-sync-user