Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

provide an option to disable haptic feedback for tabs button #1855

Closed
cadeyrn opened this issue Apr 20, 2019 · 3 comments
Closed

provide an option to disable haptic feedback for tabs button #1855

cadeyrn opened this issue Apr 20, 2019 · 3 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone
Sprint 4-2 (Miles...

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Apr 20, 2019 •
edited by data-sync-user
Loading

When pressing the tabs buttons in the address bar there is a haptic feedback. That's unexpected - neither Firefox nor Chrome does this - and it's very annoying. Please either remove this or provide an option to disable it.

From reading the code in TabCounterToolbarButton.kt I don't understand why there is a haptic feedback at all:

it.performHapticFeedback(HapticFeedbackConstants.LONG_PRESS)

… because it happens with a short press as well.

┆Issue is synchronized with this Jira Task
@LittleAngelwings
Copy link

Most of it all it's nonsense, if a device has no vibration module like Samsung Galaxy Tab A (2016) :)

@cadeyrn
Copy link
Contributor Author

cadeyrn commented Apr 23, 2019

@ekager Since you implemented TabCounterToolbarButton I have a question for you. ;-) Is this expected behaviour that there is a haptic feedback even without a long press or is this a bug? I was not sure so I didn't labeled this issue as bug. But from reading the code it looks like a bug (for me as someone who is not an Android developer).

ekager added a commit to ekager/fenix that referenced this issue Apr 23, 2019
@ekager
Closes mozilla-mobile#1855 - Remove haptic feedback on tabs button
65014d9
@ghost ghost assigned ekager Apr 23, 2019
@ghost ghost added the review label Apr 23, 2019
@vesta0 vesta0 added the 🐞 bug Crashes, Something isn't working, .. label Apr 23, 2019
@vesta0 vesta0 added this to the Sprint 4-2 (Milestone 4) milestone Apr 23, 2019
@ghost ghost removed the review label Apr 23, 2019
@vesta0 vesta0 added this to In Progress in Fenix Sprint Kanban Apr 24, 2019
@vesta0 vesta0 added the eng:qa:needed QA Needed label Apr 24, 2019
@project-bot project-bot bot moved this from In Progress to Ready for QA in Fenix Sprint Kanban Apr 24, 2019
@kbrosnan kbrosnan added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 26, 2019
@kbrosnan
Copy link
Contributor

Verified using a Nexus 5x. Requires the user to have the Vibrate on Tap setting in the Sounds section of the Android Settings.

@kbrosnan kbrosnan moved this from Ready for QA to Done in Fenix Sprint Kanban Apr 26, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title provide an option to disable haptic feedback for tabs button FNX2-17451 ⁃ provide an option to disable haptic feedback for tabs button Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17451 ⁃ provide an option to disable haptic feedback for tabs button FNX3-15863 ⁃ provide an option to disable haptic feedback for tabs button Aug 11, 2020
@cadeyrn cadeyrn closed this as completed Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15863 ⁃ provide an option to disable haptic feedback for tabs button FNX-5286 ⁃ provide an option to disable haptic feedback for tabs button Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5286 ⁃ provide an option to disable haptic feedback for tabs button provide an option to disable haptic feedback for tabs button May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
Sprint 4-2 (Milestone 4)
Development

No branches or pull requests
6 participants
@kbrosnan @cadeyrn @ekager @vesta0 @LittleAngelwings @data-sync-user