Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Resolve EngineView#InputResult deprecation from AC #18617

Closed
Mugurell opened this issue Mar 24, 2021 · 2 comments
Closed

Resolve EngineView#InputResult deprecation from AC #18617

Mugurell opened this issue Mar 24, 2021 · 2 comments
Assignees
@Mugurell
Labels
eng:qa:verified QA Verified eng:task An engineering breakout issue of a user story
Projects
Android Engineering Team Kanban board
Milestone
89

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 24, 2021 •
edited by data-sync-user

mozilla-mobile/android-components#9963 will deprecate EngineView#InputResult.

This is currently used in DynamicDownloadDialogBehavior which needs to be migrated to the new InputResultDetail api.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Mar 24, 2021
@Mugurell Mugurell added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Mar 24, 2021
@Mugurell Mugurell moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Mar 24, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 24, 2021
@Mugurell Mugurell moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Mar 24, 2021
@Mugurell Mugurell added eng:task An engineering breakout issue of a user story and removed needs:triage Issue needs triage labels Mar 24, 2021
Mugurell added a commit that referenced this issue Mar 31, 2021
@Mugurell
For #18617 - Use the new EngineView#getInputResultDetail()
304e471 
All functionality should remain the same.
@Mugurell Mugurell moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Mar 31, 2021
@Mugurell
Copy link
Contributor Author

For QA. This was just a small code refactorization. But it would help to know that the "download completed dialog" can be hidden / shown as before and nothing is broken in this functionality.

@Mugurell Mugurell added the eng:qa:needed QA Needed label Mar 31, 2021
@lobontiumira
Copy link

Verified as fixed on the 4/7 Nightly build from 4/7 with HTC 10 (Android 8), and Samsung Galaxy Note 8 (Android 9).
Downloading multiple files displays the "Download complete" dialogue. No issues encountered.

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Apr 7, 2021
@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 7, 2021
@gabrielluong gabrielluong added this to the 89 milestone Apr 8, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 6, 2021
@Mugurell @pkirakosyan
For mozilla-mobile#18617 - Use the new EngineView#getInputResultDetail()
5122e97 
All functionality should remain the same.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
eng:qa:verified QA Verified eng:task An engineering breakout issue of a user story
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
89
Development

No branches or pull requests
3 participants
@gabrielluong @Mugurell @lobontiumira