Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Firefox Browser logo and PB icon not displayed on the home screen #18815

Closed
AndiAJ opened this issue Apr 6, 2021 · 3 comments · Fixed by #18818
Closed

[Bug] Firefox Browser logo and PB icon not displayed on the home screen #18815

AndiAJ opened this issue Apr 6, 2021 · 3 comments · Fixed by #18818
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Android Engineering Team Kanban board
Milestone
89

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 6, 2021 •
edited by data-sync-user
Loading

Prerequisites

Have a fresh install or a clean profile.

Steps to reproduce

  1. Launch Fenix
  2. Tap the "Start Browsing" button
  3. Check the home screen

Expected behavior

The "Firefox Browser" logo and PB icon should be displayed on the home screen.
image

Actual behavior

It only get's displayed after close-resume or after opening a new tab.

Device information

  • Device vendor / model and Android version:
    • Google Pixel 3a (Android 11)
    • Huawei Mate 20 Lite (Android 10)
    • Pixel 2 (Android 9)
    • HTC Nexus 9 (Android 7.1.1)
    • OnePlus A3 (Android 6.0.1)

  • Firefox for Android version: Nightly 210406

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Apr 6, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 6, 2021
@AndiAJ AndiAJ removed the needs:triage Issue needs triage label Apr 6, 2021
@mcarare mcarare added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 6, 2021
@mcarare mcarare added the Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR label Apr 6, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 6, 2021
@mcarare mcarare self-assigned this Apr 6, 2021
@mcarare
Copy link
Contributor

mcarare commented Apr 6, 2021

This is a regression introduced with 3260cbd. As the homeAppBar is collapsed when the button is clicked, the fact that the screen cannot be scrolled makes it impossible to scroll and make it visible again. The easiest fix, while keeping the changes introduced in 3260cbd would be to expand the homeAppBar when the "Start Browsing" button is clicked.

mcarare added a commit to mcarare/fenix that referenced this issue Apr 6, 2021
@mcarare
For mozilla-mobile#18815: Expand app bar on onboarding dismissal and …
c0581eb 
…browsing start.
mcarare added a commit to mcarare/fenix that referenced this issue Apr 6, 2021
@mcarare
For mozilla-mobile#18815: Expand app bar on onboarding dismissal and …
8aa6445 
…browsing start.
@eliserichards eliserichards linked a pull request Apr 7, 2021 that will close this issue
For #18815: Expand app bar on onboarding dismissal and browsing start. #18818
Merged
3 tasks
@mcarare mcarare moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Apr 13, 2021
Android Engineering Team Kanban board automation moved this from Dev Complete (WIP limit - 5) to Done Apr 14, 2021
mcarare added a commit that referenced this issue Apr 14, 2021
@mcarare
For #18815: Expand app bar on onboarding dismissal and browsing start.
445091d
@mcarare mcarare moved this from Done to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Apr 14, 2021
@mcarare
Copy link
Contributor

mcarare commented Apr 14, 2021

Reopened for QA.

@mcarare mcarare reopened this Apr 14, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to In Development (WIP limit - 15) Apr 14, 2021
@mcarare mcarare added the eng:qa:needed QA Needed label Apr 14, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Apr 14, 2021
@abodea
Copy link
Member

abodea commented Apr 15, 2021

Verified as fixed on the latest Nightly 4/15 with Google Pixel 4XL (11), Samsung Galaxy S10+ (10), Samsung Galaxy S7 (7).
Note that the Firefox Browser logo and PB icon are displayed after tapping on the Start Browsing button.

@abodea abodea closed this as completed Apr 15, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Apr 15, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 15, 2021
@gabrielluong gabrielluong added this to the 89 milestone Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
89
Development

Successfully merging a pull request may close this issue.

For #18815: Expand app bar on onboarding dismissal and browsing start. mcarare/fenix
4 participants
@gabrielluong @abodea @mcarare @AndiAJ