Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Send an event when users interact with the "set as default browser" card on the new tab #18853

Closed
2 of 7 tasks
tdsmith opened this issue Apr 7, 2021 · 1 comment
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Telemetry
Milestone

Comments

@tdsmith
Copy link
Contributor

tdsmith commented Apr 7, 2021

Description & Product Manager / Data Scientist User Story

In order to understand whether we can improve the effectiveness of each messaging surface we’re testing in the set-default experiment (#18796), we should understand how many people interact directly with our message.

As a data scientist, I want to know, using a Glean event, if a user interacted with the "set as default browser" card on the new tab page, which we will test in the branch described by #18375.

Distinct events should be sent for:

  • selecting "set as default browser"
  • dismissing the card using the X icon

What questions will you answer with this data?

  • How many people clicked on the message that we presented?
  • When they set to default and the system dialog shows up, how many users actually set us as default?
    • How many people simply close the dialog and do not follow through with setting to default?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 7, 2021
@eliserichards eliserichards removed the needs:triage Issue needs triage label Apr 7, 2021
@mcarare mcarare self-assigned this Apr 8, 2021
@mcarare mcarare added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 8, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Tech Design (WIP limit - ?) in Android Engineering Team Kanban board Apr 8, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 9, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 9, 2021
@mcarare mcarare added the E3 Estimation Point: average, 2 - 3 days label Apr 9, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 12, 2021
@mcarare mcarare moved this from In Tech Design (WIP limit - ?) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 12, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 13, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 13, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Apr 13, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 14, 2021
@mcarare mcarare moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Apr 14, 2021
@lobontiumira
Copy link

Verified as fixed on a debug Nightly build #2015805929, GV 89.0a1-20210418092832 with Google Pixel (Android 10):

  • ping: f9239b73-8659-4ed7-9402-3f047419b60c
  • set_default_newtab_clicked event:
{
          "category": "set_default_newtab_experiment",
          "name": "set_default_browser_clicked",
          "timestamp": 3630
        }
  • ping: 957c1071-3033-45e6-8fbe-2224695d6b95
  • close_experiment_card_clicked event:
{
          "category": "set_default_newtab_experiment",
          "name": "close_experiment_card_clicked",
          "timestamp": 774
        }

Glean dashboard
telemetry logcat.txt

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Apr 23, 2021
@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Apr 23, 2021
@gabrielluong gabrielluong added this to the 89 milestone Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Telemetry
Projects
No open projects
Development

No branches or pull requests

5 participants