Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Saved cards] Add button for "Add credit card" #18881

Closed
gabrielluong opened this issue Apr 8, 2021 · 8 comments · Fixed by #19643
Closed

[Saved cards] Add button for "Add credit card" #18881

gabrielluong opened this issue Apr 8, 2021 · 8 comments · Fixed by #19643
Assignees
@ionutbedregeanu
Labels
cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
Android Engineering Team Kanban board Autofill
Milestone
90

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Apr 8, 2021 •
edited by data-sync-user
Loading

We have an PR for this in #19236 with some feedback on the remaining work #19236 (comment). Please consider using this.

This issue for adding a "Add credit card" button in the "Saved cards" screen. This should navigate to the credit card editor.

Screen Shot 2021-04-08 at 2 11 34 PM

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added E2 Estimation Point: easy, half a day to 2 days Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels Apr 8, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 8, 2021
@gabrielluong gabrielluong added this to Backlog in Autofill Apr 8, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 8, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Apr 8, 2021
@chrishernan
Copy link
Contributor

Hello, Could I work on this issue?

@gabrielluong
Copy link
Member Author

Hello, Could I work on this issue?

Thanks, go for it. We plan to ship the feature in the next May release so I think there is demand to pick this work up. Since no one has picked it up, I am happy to have anyone pick up work where it is reasonable. I think I do have to mention that the team can take over the issue where it is reasonable in order to hit our releasee deadline.

@gabrielluong
Copy link
Member Author

Since the list of credit cards is a RecyclerView, the only known solution I have seen is using a ConcatAdapter. I am happy to entertain other solutions if you are aware of better solutions, but I hope this points a little point of guidance. I am still fairly new with Android development.

@chrishernan
Copy link
Contributor

Gotcha. I'll look into it. I'm pretty sure you know your stuff. Because if you're new, then I'm in elementary school when it comes to this stuff. Still learning and trying to become an androi dev haha.

chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - Added Viewholder placeholder and AddCreditCard…
004984d 
…Button file.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - Added xml layout file for add button. This lay…
5e129c2 
…out was copied from preference_credit_cards_add_credit_card.xml to avoid any confusing and separate out both layouts.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - Implemented AddCreditCardButtonViewHolder. Add…
e3f14ab 
…ed an onclick listener to the view holder that will take the user to the credit card editor desitnation when add button is clicked. Implemented AddCreditCardButtonAdapter. I added id to the saved_cards_add_button.xml layout.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - changed id of layout since it was a duplicate.
2d1c94a
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - Add Credit card button is displayed to the use…
314e763 
…r in Saved Cards. It is displayed below all cards. Once the user clicks on it, they are taken to the Credit Card editor.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - Added 6 dp margin to the add credit card butto…
9f522e2 
…n. Deleted log statements and cleaned up some imports
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 19, 2021
@chrishernan
mozilla-mobile#18881 - Deleted empty line
e6abecd
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 20, 2021
@gabrielluong gabrielluong moved this from Backlog to Review in progress in Autofill Apr 20, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Apr 20, 2021
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Rebasing with master after falling behind
04ca0b7
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Added xml layout file for add button. This lay…
a9d66c2 
…out was copied from preference_credit_cards_add_credit_card.xml to avoid any confusing and separate out both layouts.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Implemented AddCreditCardButtonViewHolder. Add…
b3b7487 
…ed an onclick listener to the view holder that will take the user to the credit card editor desitnation when add button is clicked. Implemented AddCreditCardButtonAdapter. I added id to the saved_cards_add_button.xml layout.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - changed id of layout since it was a duplicate.
6dd497d
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Add Credit card button is displayed to the use…
563e0c6 
…r in Saved Cards. It is displayed below all cards. Once the user clicks on it, they are taken to the Credit Card editor.
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Added 6 dp margin to the add credit card butto…
d4394f1 
…n. Deleted log statements and cleaned up some imports
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Deleted empty line
88d939f
chrishernan added a commit to chrishernan/fenix that referenced this issue Apr 22, 2021
@chrishernan
mozilla-mobile#18881 - Added new methods to add credit card from mana…
dc2d12c 
…ge saved cards page. Will add work on navigation path next.
@gabrielluong gabrielluong moved this from In progress to Backlog in Autofill May 24, 2021
@ionutbedregeanu
Copy link
Contributor

I would like to work on this ticket

@Mugurell Mugurell moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board May 24, 2021
@Mugurell Mugurell moved this from Backlog to In progress in Autofill May 24, 2021
ionutbedregeanu pushed a commit to ionutbedregeanu/fenix that referenced this issue May 25, 2021
For mozilla-mobile#18881 - Create a new layout for 'Add credit card' …
439734e 
…button

Add functionality for 'Add credit card' button
ionutbedregeanu pushed a commit to ionutbedregeanu/fenix that referenced this issue May 25, 2021
For mozilla-mobile#18881 - Add unit tests for 'Add credit card' funct…
1118e79 
…ionality
ionutbedregeanu pushed a commit to ionutbedregeanu/fenix that referenced this issue May 25, 2021
For mozilla-mobile#18881 - Rename handleAddCreditCardClicked to handl…
c3735a5 
…eAddCreditCard
@ionutbedregeanu ionutbedregeanu mentioned this issue May 25, 2021
Merged
3 tasks
ionutbedregeanu pushed a commit to ionutbedregeanu/fenix that referenced this issue May 25, 2021
For mozilla-mobile#18881 - Create a new layout for 'Add credit card' …
04650e2 
…button

Add functionality for 'Add credit card' button

Add unit tests for 'Add credit card' functionality
@gabrielluong gabrielluong moved this from In progress to Review in progress in Autofill May 25, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board May 25, 2021
@gabrielluong gabrielluong removed a link to a pull request May 25, 2021
For #18881: [Saved cards] Add button for "Add credit card" #19236
Closed
3 tasks
@gabrielluong gabrielluong linked a pull request May 25, 2021 that will close this issue
For #18881 - Add a new button "Add credit card" in the "Saved cards" screen #19643
Merged
3 tasks
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done May 25, 2021
Mugurell pushed a commit that referenced this issue May 25, 2021
@Mugurell
For #18881 - Create a new layout for 'Add credit card' button
0a22696 
Add functionality for 'Add credit card' button

Add unit tests for 'Add credit card' functionality
Autofill automation moved this from Review in progress to Done May 25, 2021
@gabrielluong gabrielluong reopened this May 25, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) May 25, 2021
Autofill automation moved this from Done to In progress May 25, 2021
@gabrielluong gabrielluong moved this from In progress to QA in Autofill May 25, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to In Testing/QA in Android Engineering Team Kanban board May 25, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label May 25, 2021
@abodea
Copy link
Member

abodea commented May 26, 2021

Verified as fixed on the latest Nightly 5/26 with OnePlus Nord (Android 10).

@abodea abodea closed this as completed May 26, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to Done May 26, 2021
Autofill automation moved this from QA to Done May 26, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ionutbedregeanu ionutbedregeanu

Labels
cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
No open projects
Android Engineering Team Kanban board
Done
Autofill
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #18881 - Add a new button "Add credit card" in the "Saved cards" screen ionutbedregeanu/fenix
5 participants
@gabrielluong @chrishernan @ionutbedregeanu @abodea @eliserichards