Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[UX] Reader Mode #190

Closed
lime124 opened this issue Jan 16, 2019 · 32 comments
Closed

[UX] Reader Mode #190

lime124 opened this issue Jan 16, 2019 · 32 comments
Assignees
Labels
P1 Current sprint
Milestone

Comments

@lime124
Copy link
Collaborator

lime124 commented Jan 16, 2019

User story:

As a user, I want to have a clean and distraction free reading experience for longform content.

Acceptance Criteria

-As a user I want to know when reader mode is available (Reader mode indicator)
-As a user I want to be able to view a site in reader mode, have be able to change font, text size, and background)
-As a user I want to be able to go back to the browser mode when I am done reading

┆Issue is synchronized with this Jira Task

@bbinto bbinto added P2 Upcoming release and removed Non-Eng labels Jan 18, 2019
@bbinto bbinto added this to the UX Backlog milestone Jan 18, 2019
@vesta0 vesta0 added this to Milestone 2 (Q1) in Fenix MVP Jan 23, 2019
@bbinto
Copy link
Contributor

bbinto commented Jan 23, 2019

@colintheshots to identify dependencies on other teams?

@st3fan
Copy link
Contributor

st3fan commented Jan 23, 2019

Can we consider delegating this to Pocket?

@bbinto bbinto added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Feb 1, 2019
@bbinto
Copy link
Contributor

bbinto commented Feb 1, 2019

Blocked by PM to write up feature brief / user stories

@lime124
Copy link
Collaborator Author

lime124 commented Feb 12, 2019

@bbinto it seems like this is still blocked? should we move it out of milestone 2?

@bbinto
Copy link
Contributor

bbinto commented Feb 12, 2019

@vesta0 will be working on this. Let's see what Vesta says when she might have some user stories for it, depending on that we can move it.

@vesta0
Copy link
Collaborator

vesta0 commented Feb 15, 2019

Draft feature brief (includes designs from @bram)

@bbinto
Copy link
Contributor

bbinto commented Feb 15, 2019

@brampitoyo can you please size this?

@lime124 lime124 added this to To do in Fenix MVP UX via automation Feb 16, 2019
@brampitoyo
Copy link

@bbinto If we choose to go with approach 1 (integration with Pocket), then the design on my end will be quite simple: an app bar icon. The actual reader view will be handled by Pocket.

For approach 2: in addition to the app bar icon, I will also need to design the reader view itself. This can still be simple. There is prior work in Fennec that I can adapt from. However, this approach may be harder to implement, engineering-wise.

Speaking as a Fenix user, Pocket offers me a lot of super-powers (on top of the reading mode itself) like reading list, related articles, and maybe even article narration.

Speaking as Mozilla, shipping a Pocket web service in every Fenix APK isn’t only going to increase Pocket MAU. It also means that Pocket’s content recommendation will get even better from having more inputs from Fenix users. It’s like having a more accurate “Forward button” for reader view.

For those reasons, I do prefer approach 1, even though it will require cross-team coordination (we’ll need to talk to Pocket).

@brampitoyo brampitoyo moved this from To do to In progress in Fenix MVP UX Feb 18, 2019
@yoasif
Copy link
Contributor

yoasif commented Feb 18, 2019

I like Pocket and have it installed on my device.

However, given the bug around CFR on Firefox desktop where Firefox connected to Mozilla upon presenting an add-on recommendation, I think it would be pretty concerning to privacy aware Fenix users to contact an external service to provide something as basic as a reader view - unless you are simply proposing using Pocket's reader view code locally without any connection to the Pocket web service.

I don't know enough about how Pocket works to know whether all of the reader view stuff that Pocket does is local to the device, or whether it has help from the Pocket web service; I think it would be concerning if enabling reader view on a page caused Fenix to hit a pocket.com domain.

@pwd-github
Copy link

Since getting into web novels, I access reader view about 50 times a day, if not more. To be punted over to Pocket for each chapter and lose the integration with my Firefox (Global) session (History) would be a disaster.

@colintheshots
Copy link
Contributor

colintheshots commented Feb 21, 2019

Maybe we could integrate the Pocket Instant App component into the APK? That would solve two problems. We'd get Pocket for under 4MB and without requiring an external app. It would also include links to get the full app experience. It's a thought. I haven't done any analysis of this option yet, but it would be interesting to test. If the device isn't compatible with Instant Apps, such as an Amazon Fire device, we can fall back to offering to install the < 4MB instant app as its own app.

Alternatively, we could modify the Instant App for our needs and include it directly as a module in the project.

@vesta0 vesta0 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Feb 22, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Feb 22, 2019

@brampitoyo I know you are already working on this. Please also add a S/M/L size to it based on your efforts.

@pwd-github
Copy link

So here's a test case for this feature: https://www.wuxiaworld.com/novel/trash-of-the-counts-family/tcf-chapter-1

While Pocket does a wonderful job of paginating the text. There's no way to keep your place as is the default behaviour on desktop. Also for some reason, narration isn't available via Pocket. As things stand, the user experience is better in Fennec and on desktop.

@brampitoyo
Copy link

@vesta0 If we’re building our own solution – and thanks @pwd-github @yoasif for providing really good reasons for it – then I think that this would be a size S.

If we’re using Pocket’s technology, it might be a size M.

@brampitoyo
Copy link

@colintheshots Good catch.

When a page detects reader mode, we definitely want to peek the Quick Access Bar halfway up, 1) to indicate that something is different with this page, and 2) to subtly bring up the Reader Mode icon.

Since Reader Mode availability is meant to be unobstrusive, no animation will be necessary.

So from this halfway point, it’s up to the user. Want to access Reader Mode? Pull up the Quick Access Bar and then tap “Read”.

@shorlander
Copy link

@brampitoyo Do you think all of the items left in the Quick Action bar apply to pages in Reader mode? E.g. What happens if you bookmark a page in Reader mode?

@brampitoyo
Copy link

@shorlander Reader View controls are now located inside the Quick Action Bar, replacing two actions there – Download and Favorite – that would do nothing in Reader View.

Share and Screenshot still works as they should on Reader View:

  1. Share: the URL itself is shared
  2. Screenshot: a screenshot of the reader view (not of the webpage) is taken

@colintheshots @csadilek @vesta0 @lime124 I’ve updated my specs above to account for the new reader view navigation pattern: appearance and reading list actions are now located inside the Quick Action Bar).

I try not to put up a fresh new spec every time it’s updated, so we have only one source of truth.

See the new specs here: #190 (comment)

@pwd-github
Copy link

The narrate feature still seems to be missing?

@cadeyrn
Copy link
Contributor

cadeyrn commented Mar 28, 2019

Screenshot: a screenshot of the reader view (not of the webpage) is taken

I thought screenshots are no longer part of the MVP?

@vesta0 vesta0 added the needs:UX-feedback Needs UX Feedback label Mar 29, 2019
@boek
Copy link
Contributor

boek commented Mar 29, 2019

@pwd-github we would love help, but at this time our UX team is at capacity trying to provide everything we need for the MVP. Feel free to open a new ticket with the requested feature and we can prioritize it once we ship the first version 🙌

@boek boek removed the needs:UX-feedback Needs UX Feedback label Mar 29, 2019
@vesta0 vesta0 added the P1 Current sprint label Apr 9, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, UX Backlog Apr 9, 2019
@mheubusch
Copy link
Contributor

@shorlander This should have gone thru you but I don't see your approval label - can you review and confirm?

@kbrosnan kbrosnan removed the size M label Apr 27, 2019
@vesta0 vesta0 removed their assignment May 14, 2019
@vesta0
Copy link
Collaborator

vesta0 commented May 31, 2019

@mheubusch can we close this issue?

@mheubusch
Copy link
Contributor

Closing . . .

Fenix MVP UX automation moved this from Feedback from Eng to Done May 31, 2019
@data-sync-user data-sync-user changed the title [UX] Reader Mode FNX2-17490 ⁃ [UX] Reader Mode Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17490 ⁃ [UX] Reader Mode FNX3-15901 ⁃ [UX] Reader Mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15901 ⁃ [UX] Reader Mode FNX-5322 ⁃ [UX] Reader Mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5322 ⁃ [UX] Reader Mode [UX] Reader Mode May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Current sprint
Projects
No open projects
Fenix MVP
Milestone 2 (Q1)
Fenix MVP UX
  
Done
Development

No branches or pull requests