Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Three-dot menu on a new tab should not have synced tabs in it #19005

Closed
jonalmeida opened this issue Apr 13, 2021 · 3 comments · Fixed by #19037
Closed

[Bug] Three-dot menu on a new tab should not have synced tabs in it #19005

jonalmeida opened this issue Apr 13, 2021 · 3 comments · Fixed by #19037
Assignees
@eliserichards
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen.
Projects
Three-dot menu redesign Android Engineering Team Kanban board
Milestone
90

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Apr 13, 2021 •
edited by data-sync-user
Loading

Steps to reproduce

  • Ensure you have the 'Tabs tray re-write' feature flag enabled in the secret settings.
  • Open a new tab.
  • Click on the three-dot menu.

Expected behavior

  • You do not see 'Sync Tabs' in the three-dot menu list.

Actual behavior

  • You see synced tabs and not sync sign in

Device information

  • Device vendor / model and Android version: Android 11, Pixel 3
  • Firefox for Android version: master as of 5db2f75

Screen Shot 2021-04-13 at 4 19 41 PM

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Crashes, Something isn't working, .. Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. labels Apr 13, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 13, 2021
@eliserichards
Copy link
Contributor

eliserichards commented Apr 14, 2021 •
edited
Loading

Synced tabs/sync sign in were checked in the default toolbar but not in new tab. This was a miss, thanks Jon!

@eliserichards eliserichards self-assigned this Apr 14, 2021
@eliserichards eliserichards moved this from To do to In progress in Three-dot menu redesign Apr 14, 2021
@eliserichards eliserichards mentioned this issue Apr 14, 2021
Merged
3 tasks
@eliserichards eliserichards linked a pull request Apr 14, 2021 that will close this issue
For #19005: new tab three-dot menu sync sign in #19037
Merged
3 tasks
@eliserichards eliserichards added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 14, 2021
@eliserichards eliserichards moved this from Ready for Engineering (min-5 ; max-22) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Apr 14, 2021
@eliserichards eliserichards moved this from Dev Complete (WIP limit - 5) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Apr 15, 2021
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Apr 20, 2021
eliserichards added a commit that referenced this issue Apr 20, 2021
@eliserichards
For #19005: new tab three-dot menu sync sign in (#19037)
59c94e4 
* Show synced tabs or sync account in new tab menu

* Sync sign in item navigates to account settings

* Check account auth and get sync item title

* Look for sync sign in item on home menu for UI test

* Sync sign in menu item UI test
@eliserichards eliserichards moved this from In progress to Done in Three-dot menu redesign Apr 20, 2021
@gabrielluong gabrielluong added this to the 90 milestone Apr 21, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Apr 21, 2021
@gabrielluong gabrielluong moved this from Done to In Testing/QA in Android Engineering Team Kanban board Apr 21, 2021
@gabrielluong gabrielluong reopened this Apr 21, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to In Development (WIP limit - 15) Apr 21, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Apr 21, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to In Testing/QA in Android Engineering Team Kanban board Apr 21, 2021
@jonalmeida jonalmeida mentioned this issue Apr 22, 2021
Closed
@sflorean
Copy link
Contributor

Verified as fixed on latest Nightly build 4/23. Following the steps, "Sign in to sync" is displayed, that goes to Account settings/Sign In.
Devices: Pixel 3 (Android 11), Huawei MediaPad M2(Android 5.1.1).

Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Apr 23, 2021
@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 23, 2021
@jonalmeida
Copy link
Contributor Author

Uplifting the fix for this bug, will in turn also fix #19184 in beta.

eliserichards added a commit to eliserichards/fenix that referenced this issue Apr 29, 2021
@eliserichards
For mozilla-mobile#19005: new tab three-dot menu sync sign in (mozill…
b7715d9 
…a-mobile#19037)

* Show synced tabs or sync account in new tab menu

* Sync sign in item navigates to account settings

* Check account auth and get sync item title

* Look for sync sign in item on home menu for UI test

* Sync sign in menu item UI test
@eliserichards eliserichards mentioned this issue Apr 29, 2021
Merged
3 tasks
rvandermeulen pushed a commit that referenced this issue Apr 30, 2021
@eliserichards @Mugurell
No issue: uplift three dot menu redesign for beta. (#19312)
9fc6a87 
* For #19005: new tab three-dot menu sync sign in  (#19037)

* Show synced tabs or sync account in new tab menu

* Sync sign in item navigates to account settings

* Check account auth and get sync item title

* Look for sync sign in item on home menu for UI test

* Sync sign in menu item UI test

* For #19114: check state of sync account when navigating from sync sign in menu item (#19118)

* For #18591 - Make the navbar sticky in the new menu

* Turn on feature flag for three-dot menu redesign for beta. (#19111)

* For #18591 - Update tests

Some tests trying to "Add to top sites" may fail because of the sticky navbar
now covering that menu item -> scroll the menu up a little.

Some tests that previously were trying to scroll to the bottom of the menu to
interact with navbar options now don't have to. Them trying to interact with
navbar option with the menu opened as collapsed is a good test for the navbar
stickyness.

Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen.
Projects
No open projects
Android Engineering Team Kanban board
Done
Three-dot menu redesign
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #19005: new tab three-dot menu sync sign in eliserichards/fenix
4 participants
@gabrielluong @jonalmeida @eliserichards @sflorean