[Bug] Flash of black when leaving GV engine

[mcomella]

Dependencies

• Maybe Graphics bug in GV/Gecko

Steps to reproduce

• Load a page
• Press tabs button

Expected behavior

Tabs screen appears smoothly (with animation?)

Actual behavior

There's a flash of black (or white, depending on Light/Dark mode) and the tabs screen suddenly appears

This also happens when creating a new tab from an open tab (i.e. load page, click 3-dot, select "New tab")

Next steps

GV doesn't think this is a Gecko problem, but rather a problem in Fenix not destroying the SurfaceView in time. So the next steps here are to verify that we're handling the SurfaceView correctly.

I'm not convinced the black flash when navigating away is graphics' fault. We set everything inactive in GeckoView.Display.onSurfaceDestroyed(), which I presume happens when the SurfaceView is destroyed by navigating away from the browser fragment. No rendering can occur after this point. I'm not sure what we could do, when we don't have a surface to render in to. Isn't the problem that there is a delay between the SurfaceView being destroyed and the TabsFragment being created and shown? So the android UI displays black during this time.

Device information

• Android device: Pixel 2
• Fenix version: 1.0.1917

---

Edit by @sblatz

Acceptance Criteria

• I do not see a black/white flash when moving from browser -> Settings
• I do not see a black/white flash when moving from browser -> Library
• I do not see a black/white flash when moving from browser -> Fenix Home
  (black/white flash depending on if user is in Dark/Light Mode)

┆Issue is synchronized with this Jira Task

[yoasif]

I noticed this on a Moto G today. Screencast attached.

recording_20190426_232847.zip

[sv-ohorvath]

Still reproducing on 5/23 build. Pixel and Galaxy Note 8.

[sblatz]

The only way for us to handle this is to "screenshot" the GV and animate with that.
We should consider handling the bugs surrounding this all at one time since there's a few mentioning it.

[sblatz]

Demo of the behavior:

I will link to the other related issues since it will be the same underlying fix 😄

[sblatz]

Basically the same issue as #4708 but lets make sure that animation looks good too (navigate from browser -> home).

[AndiAJ]

Hi, verified as fixed on the latest Nightly Build #20560606 from 02/25 using the following devices:
• Google Pixel 3a XL (Android 10)
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

Dark theme time lapsed videos (Dropdown)

► Moving from browser -> Fenix Home

► Moving from browser -> Library

► Moving from browser -> Settings

Light theme time lapsed videos (Dropdown)

► Moving from browser -> Fenix Home

► Moving from browser -> Library

► Moving from browser -> Settings