Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Homescreen is not scrollable to see collections #19030

Closed
jonalmeida opened this issue Apr 14, 2021 · 3 comments
Closed

[Bug] Homescreen is not scrollable to see collections #19030

jonalmeida opened this issue Apr 14, 2021 · 3 comments
Assignees
@jonalmeida
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen
Projects
Android Engineering Team Kanban board
Milestone
89

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Apr 14, 2021 •
edited by data-sync-user

Steps to reproduce

  1. Open a few collections (2 seem enough).
  2. Try to scroll in the home screen.

Expected behaviour

  • The home screen should scroll.

Actual behaviour

  • We can scroll down to the end of collections.

Device information

  • Device vendor / model and Android version: Android 10, Pixel 3
  • Firefox for Android version: ? (go to Settings -> About Firefox) Nightly 210412
device-2021-04-14-125047.mp4

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen labels Apr 14, 2021
@jonalmeida jonalmeida self-assigned this Apr 14, 2021
@jonalmeida jonalmeida added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 14, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 14, 2021
@jonalmeida
Copy link
Contributor Author

This bug came up from the fix in #8545 which I'm going to revert for now.

Android Engineering Team Kanban board automation moved this from Ready for Engineering (min-5 ; max-22) to Done Apr 14, 2021
@jonalmeida jonalmeida mentioned this issue Apr 14, 2021
Closed
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Apr 14, 2021
@jonalmeida
Issue mozilla-mobile#19030: Allow homescreen to be scrollable with ex…
132f71f 
…tra content
@gabrielluong gabrielluong added this to the 89 milestone Apr 14, 2021
@gabrielluong gabrielluong mentioned this issue Apr 14, 2021
Merged
3 tasks
@jonalmeida jonalmeida mentioned this issue Apr 15, 2021
Closed
@jonalmeida
Copy link
Contributor Author

jonalmeida commented Apr 15, 2021 •
edited

Hmm.. must have closed the bug in error.

Will close after the change lands and QA verifies.

@jonalmeida jonalmeida reopened this Apr 15, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Apr 15, 2021
jonalmeida added a commit that referenced this issue Apr 15, 2021
@jonalmeida
Issue #19030: Allow homescreen to be scrollable with extra content
72c13f8
@jonalmeida jonalmeida added eng:qa:needed QA Needed and removed needs:triage Issue needs triage labels Apr 15, 2021
@VaishnaviShri VaishnaviShri mentioned this issue Apr 18, 2021
Merged
3 tasks
@lobontiumira
Copy link

Verified as fixed on the 4/20 Nightly build with Samsung Galaxy Note 8 (Android 9, and Google Pixel (Android 10).
The homescreen is scrollable, the collections are visible.

Android Engineering Team Kanban board automation moved this from In Development (WIP limit - 15) to Done Apr 20, 2021
@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 20, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 9, 2021
@jonalmeida @pkirakosyan
Issue mozilla-mobile#19030: Allow homescreen to be scrollable with ex…
718b51f 
…tra content
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
89
Development

No branches or pull requests
3 participants
@gabrielluong @jonalmeida @lobontiumira