Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix button arrangement in the Credit Card Editor Fragment #19055

Closed
gabrielluong opened this issue Apr 15, 2021 · 2 comments · Fixed by #19117
Closed

Fix button arrangement in the Credit Card Editor Fragment #19055

gabrielluong opened this issue Apr 15, 2021 · 2 comments · Fixed by #19117
Assignees
@kglazko
Labels
cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days Feature:Autofill Address and Credit Card autofill
Projects
Android Engineering Team Kanban board Autofill
Milestone
90

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Apr 15, 2021 •
edited by data-sync-user

deleteCcUx.mp4
  • the bottom buttons are not available in landscape (they don't fit the screen and cannot scroll to them)
  • the delete button (all buttons) is pushed up by the keyboard and remain there even after the keyboard is dismissed

Originally posted by @Mugurell in #19029 (comment)

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 15, 2021
@gabrielluong
Copy link
Member Author

The CreditCardEditorFragment is currently using a LinearLayout and the buttons are arranged using a ConstraintLayout. We should consider also converting the entire fragment layout to use ConstraintLayout I think. Please investigate this carefully.

@gabrielluong gabrielluong added cc-autofill Autofill credit card Feature:Autofill Address and Credit Card autofill E2 Estimation Point: easy, half a day to 2 days and removed needs:triage Issue needs triage labels Apr 15, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 15, 2021
@gabrielluong gabrielluong added this to Backlog in Autofill Apr 15, 2021
@gabrielluong gabrielluong mentioned this issue Apr 15, 2021
Merged
3 tasks
@kglazko
Copy link
Contributor

kglazko commented Apr 15, 2021

Hey I was wondering if I can work on this one this sprint.

@kglazko kglazko self-assigned this Apr 15, 2021
@gabrielluong gabrielluong moved this from Backlog to In progress in Autofill Apr 16, 2021
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 16, 2021
kglazko pushed a commit to kglazko/fenix that referenced this issue Apr 19, 2021
For mozilla-mobile#19055: Fix Button Arrangement Credit Card Editor F…
9e9f655 
…ragment
kglazko pushed a commit to kglazko/fenix that referenced this issue Apr 19, 2021
For mozilla-mobile#19055: Fix Button Arrangement Credit Card Editor F…
938178e 
…ragment
@kglazko kglazko moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Apr 19, 2021
@kglazko kglazko moved this from Review in progress (WIP limit - 11) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Apr 19, 2021
kglazko pushed a commit to kglazko/fenix that referenced this issue Apr 20, 2021
For mozilla-mobile#19055: Fix Button Arrangement Credit Card Editor F…
9f79e2f 
…ragment
kglazko pushed a commit to kglazko/fenix that referenced this issue Apr 20, 2021
For mozilla-mobile#19055: Implement ConstraintLayout
5dba8a2
@gabrielluong gabrielluong moved this from In progress to Review in progress in Autofill Apr 21, 2021
kglazko pushed a commit to kglazko/fenix that referenced this issue Apr 21, 2021
For mozilla-mobile#19055: Fix Button Arrangment Credit Card Editor Fr…
d568c1a 
…agment
@gabrielluong gabrielluong moved this from Dev Complete (WIP limit - 5) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Apr 22, 2021
@gabrielluong gabrielluong linked a pull request Apr 26, 2021 that will close this issue
For #19055: Fix Button Arrangement Credit Card Editor Fragment #19117
Merged
3 tasks
@gabrielluong gabrielluong added this to the 90 milestone Apr 26, 2021
kglazko pushed a commit to kglazko/fenix that referenced this issue Apr 29, 2021
For mozilla-mobile#19055: Fix Button Arrangment Credit Card Editor Fr…
0316c6e 
…agment
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done May 5, 2021
Autofill automation moved this from Review in progress to Done May 5, 2021
gabrielluong pushed a commit that referenced this issue May 5, 2021
@kglazko
For #19055 - Add a ScrollView to the Credit Card Editor Fragment (#19117
008c523 
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kglazko kglazko

Labels
cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days Feature:Autofill Address and Credit Card autofill
Projects
No open projects
Android Engineering Team Kanban board
Done
Autofill
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #19055: Fix Button Arrangement Credit Card Editor Fragment kglazko/fenix
2 participants
@gabrielluong @kglazko