Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Change border radius for top sites favicons from 0 to 4dp #19281

Closed
brampitoyo opened this issue Apr 28, 2021 · 0 comments · Fixed by #19392
Closed

Change border radius for top sites favicons from 0 to 4dp #19281

brampitoyo opened this issue Apr 28, 2021 · 0 comments · Fixed by #19392
Assignees
@mcarare
Labels
Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
Android Engineering Team Kanban board
Milestone
90

Comments

@brampitoyo
Copy link

brampitoyo commented Apr 28, 2021 •
edited by data-sync-user

Based on Figma, the border radius for the top sites favicons should be 4dp, rather than 0 – https://www.figma.com/file/lfgj15zbNkL9Pp4hdZGJgp/Proton-Mobile-UI?node-id=809%3A1

Screen Shot 2021-04-28 at 2 46 30 PM

┆Issue is synchronized with this Jira Task
@brampitoyo brampitoyo added the Feature:Shortcuts Top Sites/Topsites on the Firefox home page label Apr 28, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 28, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Apr 28, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Apr 28, 2021
@mcarare mcarare self-assigned this Apr 29, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Apr 29, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 5, 2021
@mcarare
For mozilla-mobile#19281: Add border radius for top sites favicons.
1a71572
@gabrielluong gabrielluong mentioned this issue May 5, 2021
Merged
3 tasks
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board May 5, 2021
@gabrielluong gabrielluong added this to the 90 milestone May 5, 2021
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done May 6, 2021
mcarare added a commit that referenced this issue May 6, 2021
@mcarare
For #19281: Add border radius for top sites favicons.
32d7b78
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #19281: Add border radius for top sites favicons. mcarare/fenix
3 participants
@brampitoyo @gabrielluong @mcarare