Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] [a11y] Card number and name edit boxes do not have an a11y label #19419

Closed
mcarare opened this issue May 7, 2021 · 8 comments · Fixed by #19762
Closed

[Bug] [a11y] Card number and name edit boxes do not have an a11y label #19419

mcarare opened this issue May 7, 2021 · 8 comments · Fixed by #19762
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. cc-autofill Autofill credit card eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
Autofill Android Engineering Team Kanban board
Milestone
91

Comments

@mcarare
Copy link
Contributor

mcarare commented May 7, 2021 •
edited by data-sync-user

Steps to reproduce

Open "Add card" screen with Talkback on.

Expected behavior

Input edit boxes should have a label as a hint to what is expected to be inputted by the user.

Actual behavior

Input edit boxes do not have a label as a hint to what is expected to be inputted by the user. They just have a text box that serves as a label just vissually.

Device information

  • Device vendor / model and Android version: ?
  • Firefox for Android version: ? (go to Settings -> About Firefox)

Note: The edit credit card screen has the same issue.

┆Issue is synchronized with this Jira Task
@mcarare mcarare added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels May 7, 2021
@mcarare mcarare added this to Stories to Breakdown and Size in Android Team Backlog Staging Board May 7, 2021
@mcarare mcarare added this to Backlog in Autofill May 7, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label May 7, 2021
@mcarare mcarare added the needs:UX-feedback Needs UX Feedback label May 7, 2021
@mcarare
Copy link
Contributor Author

mcarare commented May 7, 2021

For UX: This could have been avoided if the input boxes would have had the same design as those for adding custom search engines. Is that something UX would consider changing, or should we adjust a11y to follow the current add credit card screen design? Thank you!

@mcarare mcarare mentioned this issue May 7, 2021
Closed
@priyanka0906
Copy link
Contributor

@mcarare may I work on this.

@mcarare
Copy link
Contributor Author

mcarare commented May 7, 2021

@priyanka0906 We should wait for UX feedback on this.

@priyanka0906
Copy link
Contributor

@priyanka0906 We should wait for UX feedback on this.

@mcarare okay.

@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation May 10, 2021
@gabrielluong gabrielluong removed this from Stories to Breakdown and Size in Android Team Backlog Staging Board May 10, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Tech Design (WIP limit - ?) in Android Engineering Team Kanban board May 13, 2021
@amedyne
Copy link
Contributor

amedyne commented May 13, 2021

Tagging @topotropic

@topotropic
Copy link

We should do an audit of our forms and align them – that might take a moment. I'll add it to my list.

@topotropic topotropic added needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility and removed needs:UX-feedback Needs UX Feedback labels May 17, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label May 19, 2021
@mcarare mcarare self-assigned this Jun 2, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Jun 2, 2021
@mcarare
For mozilla-mobile#19419: Label edit boxes for a11y services.
03dac7a
@mcarare mcarare mentioned this issue Jun 2, 2021
Closed
@mcarare
Copy link
Contributor Author

mcarare commented Jun 2, 2021

Added a quick fix for this in #19762. The present issue is independent of the UX task related to forms investigation, so that issue will be tracked in #19763.

@mcarare mcarare removed the needs:UX-investigation Issues where UX needs to define or scope a solution or determine feasibility label Jun 2, 2021
@mcarare mcarare moved this from In Tech Design (WIP limit - ?) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jun 2, 2021
@mcarare mcarare moved this from Backlog to Dev Complete in Autofill Jun 2, 2021
@gabrielluong gabrielluong added this to the 91 milestone Jun 2, 2021
gabrielluong pushed a commit that referenced this issue Jun 2, 2021
@mcarare
For #19419 - Label edit boxes for a11y services. (#19762)
318aace
@gabrielluong gabrielluong mentioned this issue Jun 2, 2021
Merged
3 tasks
@gabrielluong gabrielluong moved this from Dev Complete (WIP limit - 5) to In Testing/QA in Android Engineering Team Kanban board Jun 2, 2021
@gabrielluong gabrielluong moved this from Dev Complete to QA in Autofill Jun 2, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Jun 2, 2021
@abodea
Copy link
Member

abodea commented Jun 4, 2021

Verified as fixed on the Nightly 6/4 with Google Pixel 4 XL (Android 11).
Note that the Card Number and Name on Card edit box are read correctly.

@abodea abodea closed this as completed Jun 4, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Jun 4, 2021
Autofill automation moved this from QA to Done Jun 4, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 4, 2021
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Jun 15, 2021
@mcarare
For mozilla-mobile#19419 - Label edit boxes for a11y services. (mozil…
53591ef 
…la-mobile#19762)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. cc-autofill Autofill credit card eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
No open projects
Android Engineering Team Kanban board
Done
Autofill
Done
Milestone
91
Development

Successfully merging a pull request may close this issue.

For #19419: Label edit boxes for a11y services. mcarare/fenix
6 participants
@topotropic @gabrielluong @abodea @mcarare @priyanka0906 @amedyne