Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add prompt before loading QR code #1955

Closed
kbrosnan opened this issue Apr 23, 2019 · 6 comments
Closed

Add prompt before loading QR code #1955

kbrosnan opened this issue Apr 23, 2019 · 6 comments
Assignees
@colintheshots
Labels
eng:qa:verified QA Verified Feature:QRCode P1 Current sprint
Milestone
Sprint 5-1 (Miles...

Comments

@kbrosnan
Copy link
Contributor

kbrosnan commented Apr 23, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  • Open fenix and tap into the address bar
  • tap on the scan button
  • Scan a QR code

Expected behavior

  • User action is required to load a URL/preform a search

Actual behavior

  • URL / Search is automatically preformed

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
@kbrosnan kbrosnan added 🐞 bug Crashes, Something isn't working, .. Feature:QRCode labels Apr 23, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 23, 2019

@kbrosnan I believe this is intended behaviour. @mheubusch please confirm.

@vesta0 vesta0 added this to the Bugs milestone Apr 23, 2019
@kbrosnan
Copy link
Contributor Author

The user can't know what the QR code contains. Providing some feedback on what information the user is getting from the QR code would prevent the user from getting an unexpected destination. Could we have the user confirm the information retrieved is useful?

| https://evil.example.com |
|          [Load] [Cancel] |

|              Evil string |
|        [Search] [Cancel] |

@colintheshots
Copy link
Contributor

We're well aware of this and were seeking feedback on the exact message.

@vesta0 vesta0 added the P1 Current sprint label Apr 24, 2019
@topotropic
Copy link

@colintheshots We can show a prompt similar to what we do when we ask for permission.
Prompt

@vesta0 vesta0 added this to Ready for Dev in Fenix Sprint Kanban Apr 24, 2019
@vesta0 vesta0 modified the milestones: Bugs, Sprint 5-1 (Milestone 5) Apr 24, 2019
@vesta0 vesta0 removed the 🐞 bug Crashes, Something isn't working, .. label Apr 24, 2019
@vesta0 vesta0 changed the title [Bug] adress bar QR code is automatically loaded Add promot before loading QR code Apr 24, 2019
@ghost ghost moved this from Ready for Dev to Beta 2 (Temp & Don't pick these up) in Fenix Sprint Kanban Apr 24, 2019
@kbrosnan kbrosnan changed the title Add promot before loading QR code Add prompt before loading QR code Apr 26, 2019
@colintheshots colintheshots self-assigned this Apr 26, 2019
@colintheshots
Copy link
Contributor

@topotropic Is it okay if I use quotes or italics for the URL part? Not all barcodes contain URLs. It could be an ISBN for a book, for example?

@vesta0 vesta0 moved this from Ready for Dev (To be done after Friday) to Ready for Dev (must be done by EOD Friday) in Fenix Sprint Kanban Apr 26, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue Apr 26, 2019
@colintheshots
For mozilla-mobile#1955: Add prompt before loading QR code
6afe5ec
colintheshots added a commit to colintheshots/fenix that referenced this issue Apr 26, 2019
@colintheshots
For mozilla-mobile#1955: Add prompt before loading QR code
19936bd
colintheshots added a commit to colintheshots/fenix that referenced this issue Apr 26, 2019
@colintheshots
For mozilla-mobile#1955: Add prompt before loading QR code
8c9d545
colintheshots added a commit to colintheshots/fenix that referenced this issue Apr 26, 2019
@colintheshots
For mozilla-mobile#1955: Add prompt before loading QR code
6ba579b
colintheshots added a commit that referenced this issue Apr 28, 2019
@colintheshots
For #1955: Add prompt before loading QR code (#2096)
5b7e297
@colintheshots colintheshots added the eng:qa:needed QA Needed label May 1, 2019
@project-bot project-bot bot moved this from Ready for Dev to Ready for QA in Fenix Sprint Kanban May 1, 2019
@colintheshots colintheshots moved this from Ready for QA to In Progress in Fenix Sprint Kanban May 1, 2019
@colintheshots colintheshots moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 1, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed on Master. build 5/2.

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label May 2, 2019
@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label May 2, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 2, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title Add prompt before loading QR code FNX2-17530 ⁃ Add prompt before loading QR code Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17530 ⁃ Add prompt before loading QR code FNX3-15935 ⁃ Add prompt before loading QR code Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15935 ⁃ Add prompt before loading QR code FNX-5350 ⁃ Add prompt before loading QR code Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5350 ⁃ Add prompt before loading QR code Add prompt before loading QR code May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
eng:qa:verified QA Verified Feature:QRCode P1 Current sprint
Projects
None yet
Milestone
Sprint 5-1 (Milestone 5)
Development

No branches or pull requests
6 participants
@kbrosnan @topotropic @colintheshots @sv-ohorvath @vesta0 @data-sync-user