Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "Sync cards" is disabled when it's enabled for the account #19554

Closed
mhammond opened this issue May 19, 2021 · 2 comments · Fixed by #19623
Closed

[Bug] "Sync cards" is disabled when it's enabled for the account #19554

mhammond opened this issue May 19, 2021 · 2 comments · Fixed by #19623
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. cc-autofill Autofill credit card eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
Android Engineering Team Kanban board Autofill
Milestone
90

Comments

@mhammond
Copy link
Contributor

mhammond commented May 19, 2021 •
edited by data-sync-user

STR:

  • Have Fenix signed in to an existing account where credit-cards are configured to sync (ie, presumably configured that way on a desktop profile)
  • Jump through the hoops to enable CC autofill on Fenix.
  • View "Credit cards" preferences - note the "Sync cards" option - it should be enabled but is disabled.

(I'll try and dig into this, but opening it now so I don't forget. For all I know it is permanently disabled and there's a TODO to enable it :) Note that the state of this checkbox will not come from the new autofill component, but instead via the "sync manager" component)

┆Issue is synchronized with this Jira Task
@mhammond mhammond added the 🐞 bug Crashes, Something isn't working, .. label May 19, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label May 19, 2021
@mcarare mcarare added the cc-autofill Autofill credit card label May 20, 2021
@mcarare mcarare mentioned this issue May 20, 2021
Closed
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation May 20, 2021
@gabrielluong gabrielluong added the Feature:Autofill Address and Credit Card autofill label May 20, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label May 20, 2021
@gabrielluong gabrielluong added this to the 90 milestone May 20, 2021
@gabrielluong gabrielluong added this to Backlog in Autofill May 24, 2021
@mcarare mcarare self-assigned this May 24, 2021
@mcarare mcarare moved this from Ready for Engineering (min-5 ; max-22) to In Tech Design (WIP limit - ?) in Android Engineering Team Kanban board May 24, 2021
@mcarare mcarare moved this from Backlog to In progress in Autofill May 24, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 24, 2021
@mcarare
For mozilla-mobile#19554: Add SyncEngine.CreditCards to sync supporte…
5a87808 
…dEngines.
mcarare added a commit to mcarare/fenix that referenced this issue May 24, 2021
@mcarare
For mozilla-mobile#19554: Add SyncEngine.CreditCards to sync supporte…
b9b5fa4 
…dEngines.
mcarare added a commit to mcarare/fenix that referenced this issue May 24, 2021
@mcarare
For mozilla-mobile#19554: Add SyncEngine.CreditCards to sync supporte…
1a7fd60 
…dEngines.
@gabrielluong gabrielluong mentioned this issue May 24, 2021
Merged
3 tasks
@gabrielluong gabrielluong moved this from In progress to Reviewer approved in Autofill May 24, 2021
@gabrielluong gabrielluong moved this from In Tech Design (WIP limit - ?) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board May 24, 2021
Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done May 25, 2021
Autofill automation moved this from Reviewer approved to Done May 25, 2021
mcarare added a commit that referenced this issue May 25, 2021
@mcarare
For #19554: Add SyncEngine.CreditCards to sync supportedEngines.
0141d96
@mcarare mcarare added the eng:qa:needed QA Needed label May 25, 2021
@mcarare
Copy link
Contributor

mcarare commented May 25, 2021

Reopened for QA.

@mcarare mcarare reopened this May 25, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) May 25, 2021
Autofill automation moved this from Done to In progress May 25, 2021
@mcarare mcarare moved this from In progress to QA in Autofill May 25, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board May 25, 2021
@gabrielluong gabrielluong moved this from Reviewer approved, ready for test (WIP limit - ?) to In Testing/QA in Android Engineering Team Kanban board May 25, 2021
@abodea
Copy link
Member

abodea commented May 26, 2021

Verified as fixed on the latest Nightly 5/26 with OnePlus Nord (Android 10).
Please note that after I signed in, I checked the Sync card but it was off.
After the account synced it turned ON, but I do believe this is the intended behavior, so after a sign-in and then sync, it should be enabled.
@gabrielluong if you can confirm please that this is the intended behavior, thank you!

@abodea abodea closed this as completed May 26, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to Done May 26, 2021
Autofill automation moved this from QA to Done May 26, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. cc-autofill Autofill credit card eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
No open projects
Android Engineering Team Kanban board
Done
Autofill
Done
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #19554: Add SyncEngine.CreditCards to sync supportedEngines. mcarare/fenix
5 participants
@mhammond @gabrielluong @abodea @mcarare @amedyne