Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] [TabsTray] Tab previews are cut off #19815

Closed
Mugurell opened this issue Jun 4, 2021 · 1 comment
Closed

[Bug] [TabsTray] Tab previews are cut off #19815

Mugurell opened this issue Jun 4, 2021 · 1 comment
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jun 4, 2021

As in the previous implementation (as seen in the current release version of the app) tabs should expand to the bottom of the screen.
In the current Nightly they are cut off. Both in portrait and landscape, both when shown as list or as grid.

TabAreCutOff.mp4

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. Feature:Tabs labels Jun 4, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 4, 2021
@gabrielluong gabrielluong added this to Triage in Tabs Tray via automation Jun 4, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jun 4, 2021
@gabrielluong gabrielluong added this to Backlog in Tabs Tray Refactor via automation Jun 4, 2021
@gabrielluong gabrielluong removed this from Triage in Tabs Tray Jun 4, 2021
@codrut-topliceanu codrut-topliceanu self-assigned this Jun 7, 2021
@codrut-topliceanu codrut-topliceanu moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jun 7, 2021
@codrut-topliceanu codrut-topliceanu moved this from Backlog to In progress in Tabs Tray Refactor Jun 7, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jun 8, 2021
@codrut-topliceanu codrut-topliceanu moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jun 8, 2021
@codrut-topliceanu codrut-topliceanu removed the needs:triage Issue needs triage label Jun 8, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jun 8, 2021
codrut-topliceanu added a commit that referenced this issue Jun 9, 2021
* For #19815 - Keeps tabTray FAB from obstructing last tab
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Jun 15, 2021
@codrut-topliceanu codrut-topliceanu moved this from Dev Complete (WIP limit - 5) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Jun 16, 2021
@lobontiumira
Copy link

Verified as fixed on the 6/17 Nightly build with Samsung Galaxy Tab A6 (Android 5.1.1), OnePlus 5T (Android 10), and Google Pixel (Android 10).

Android Engineering Team Kanban board automation moved this from Reviewer approved, ready for test (WIP limit - ?) to Done Jun 17, 2021
Tabs Tray Refactor automation moved this from In progress to Done Jun 17, 2021
@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 17, 2021
@gabrielluong gabrielluong added this to the 91 milestone Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs
Projects
No open projects
Development

No branches or pull requests

4 participants