Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Show a Home screen button to navigate to the home screen #19876

Closed
gabrielluong opened this issue Jun 7, 2021 · 6 comments · Fixed by #19879
Closed

Show a Home screen button to navigate to the home screen #19876

gabrielluong opened this issue Jun 7, 2021 · 6 comments · Fixed by #19879
Assignees
@gabrielluong @jonalmeida
Labels
eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
Android Engineering Team Kanban board
Milestone
91

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jun 7, 2021 •
edited by data-sync-user
Loading

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added the Feature:Toolbar Address bar, see also Feature:Search label Jun 7, 2021
@gabrielluong gabrielluong added this to the 91 milestone Jun 7, 2021
@gabrielluong gabrielluong self-assigned this Jun 7, 2021
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jun 7, 2021
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jun 7, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 7, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 7, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 1: Refactor BrowserToolbarInteractor
129a639 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 7, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 2: Add a Home screen button to the br…
b90d8a3 
…owser toolbar
@gabrielluong gabrielluong mentioned this issue Jun 7, 2021
Merged
3 tasks
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to Review in progress (WIP limit - 11) in Android Engineering Team Kanban board Jun 7, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jun 7, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 7, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 1: Refactor BrowserToolbarInteractor
7e57334 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 7, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 2: Add a Home screen button to the br…
cf94fcf 
…owser toolbar
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 8, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 1: Refactor BrowserToolbarInteractor
d975dea 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 8, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 2: Add a Home screen button to the br…
43b9252 
…owser toolbar
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 8, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 1: Refactor BrowserToolbarInteractor
3ee8ea1 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 8, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 2: Add a Home screen button to the br…
e62a8f5 
…owser toolbar
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 8, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 3: Add a FeatureFlag to keep the Home…
081aa28 
… screen button in Nightly
Android Engineering Team Kanban board automation moved this from Review in progress (WIP limit - 11) to Done Jun 8, 2021
gabrielluong added a commit that referenced this issue Jun 8, 2021
@gabrielluong
For #19876 - Part 1: Refactor BrowserToolbarInteractor
86a9c56 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
gabrielluong added a commit that referenced this issue Jun 8, 2021
@gabrielluong
For #19876 - Part 2: Add a Home screen button to the browser toolbar
044c9a5
gabrielluong added a commit that referenced this issue Jun 8, 2021
@gabrielluong
For #19876 - Part 3: Add a FeatureFlag to keep the Home screen button…
ace835d 
… in Nightly
@amedyne amedyne mentioned this issue Jun 10, 2021
Closed
7 tasks
@gabrielluong gabrielluong moved this from Done to In Testing/QA in Android Engineering Team Kanban board Jun 10, 2021
@gabrielluong gabrielluong reopened this Jun 10, 2021
Android Engineering Team Kanban board automation moved this from In Testing/QA to In Development (WIP limit - 15) Jun 10, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Jun 10, 2021
@gabrielluong gabrielluong moved this from In Development (WIP limit - 15) to Reviewer approved, ready for test (WIP limit - ?) in Android Engineering Team Kanban board Jun 10, 2021
@gabrielluong gabrielluong moved this from Reviewer approved, ready for test (WIP limit - ?) to In Testing/QA in Android Engineering Team Kanban board Jun 10, 2021
@lobontiumira
Copy link

Verified as fixed on the 6/11 Nightly build with OnePlus 5T (Android 10), Google Pixel (Android 10), and Samsung Galaxy Tab A6 (Android 5.1.1).

Android Engineering Team Kanban board automation moved this from In Testing/QA to Done Jun 11, 2021
@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 11, 2021
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Jun 15, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 1: Refactor BrowserToolbarInteractor
d92f95d 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Jun 15, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 2: Add a Home screen button to the br…
50b0eeb 
…owser toolbar
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Jun 15, 2021
@gabrielluong
For mozilla-mobile#19876 - Part 3: Add a FeatureFlag to keep the Home…
897d9e7 
… screen button in Nightly
@lobontiumira
Copy link

lobontiumira commented Jul 23, 2021 •
edited
Loading

The Home screen button is not displayed on the page's toolbar, on Beta 91.0.0-beta.3 on any device.
@gabrielluong, @amedyne is this expected? That the home screen button is only displayed in Nightly?
But, the options to "Start on home" are available and working as expected.

@amedyne
Copy link
Contributor

amedyne commented Jul 28, 2021

@lobontiumira The HomeScreen button should only be displayed in Nightly. Can you clarify what you are referring to on "options to Start on Home"?

@lobontiumira
Copy link

@amedyne I'm reffering to the options available in Settings - Tabs - Start on home.

@amedyne
Copy link
Contributor

amedyne commented Jul 28, 2021

@lobontiumira We will have to put the "Start on Home" settings on a nightly only feature flag. @Amejia481 will be doing that.

@Amejia481 Amejia481 mentioned this issue Jul 28, 2021
Merged
3 tasks
@Amejia481
Copy link
Contributor

Amejia481 commented Jul 28, 2021 •
edited
Loading

@lobontiumira We will have to put the "Start on Home" settings on a nightly only feature flag. @Amejia481 will be doing that.

This is the PR for only showing the feature on nightly, after it gets merged I'll uplift it to Beta.

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 11, 2021
@gabrielluong @pkirakosyan
For mozilla-mobile#19876 - Part 1: Refactor BrowserToolbarInteractor
63f91d7 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 11, 2021
@gabrielluong @pkirakosyan
For mozilla-mobile#19876 - Part 2: Add a Home screen button to the br…
2385c73 
…owser toolbar
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 11, 2021
@gabrielluong @pkirakosyan
For mozilla-mobile#19876 - Part 3: Add a FeatureFlag to keep the Home…
5c56a63 
… screen button in Nightly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

@jonalmeida jonalmeida

Labels
eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
91
Development

Successfully merging a pull request may close this issue.

For #19876 - Add a Home screen button to the browser toolbar gabrielluong/fenix
5 participants
@Amejia481 @gabrielluong @jonalmeida @lobontiumira @amedyne