Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: SettingsPrivacyTest.launchLinksInPrivateToggleOffStateDoesntChangeTest fails locally on Pixel 2 (smaller screen devices?) #20540

Closed
mcomella opened this issue Jul 27, 2021 · 0 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage

Comments

@mcomella
Copy link
Contributor

mcomella commented Jul 27, 2021

Steps to reproduce

  1. On the main branch, on a Pixel 2 (or perhaps any other device with a smaller screen such that the 3-dot menu requires 2 swipes to display the "Settings" menu item)...
  2. Run SettingsPrivacyTest.launchLinksInPrivateToggleOffStateDoesntChangeTest

Expected behaviour

Test passes

Actual behaviour

Test fails with

androidx.test.uiautomator.UiObjectNotFoundException: UiSelector[SCROLLABLE=true]
at androidx.test.uiautomator.UiScrollable.scrollBackward(UiScrollable.java:496)
at androidx.test.uiautomator.UiScrollable.scrollToBeginning(UiScrollable.java:544)
at androidx.test.uiautomator.UiScrollable.scrollToBeginning(UiScrollable.java:563)
at androidx.test.uiautomator.UiScrollable.scrollIntoView(UiScrollable.java:265)
at androidx.test.uiautomator.UiScrollable.scrollTextIntoView(UiScrollable.java:336)
at org.mozilla.fenix.helpers.TestHelper.scrollToElementByText(TestHelper.kt:52)
at org.mozilla.fenix.ui.robots.SettingsRobot$Transition.openPrivateBrowsingSubMenu(SettingsRobot.kt:209)
at org.mozilla.fenix.ui.SettingsPrivacyTest.launchLinksInPrivateToggleOffStateDoesntChangeTest(SettingsPrivacyTest.kt:356)

I believe what is happening is the settings menu is not opened right before openPrivateBrowsingSubMenu is called https://searchfox.org/mozilla-mobile/rev/becaeeb6fe4268631ff8155be9f3662917ee1bb3/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt#356 so openPrivateBrowsingSubMenu throws an assertion error because it doesn't see the text it's supposed to see. I think the reason the Settings menu isn't opened is because the 3-dot menu now requires a click and two swipes up to reach the bottom – perhaps the automated clicks are occurring too quickly.

Device name

Google Pixel 2

Android version

?

Firefox release type

Firefox Nightly

Firefox version

main branch: e2af42a

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

@mcomella mcomella added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage labels Jul 27, 2021
@mcomella mcomella self-assigned this Jul 27, 2021
@mcomella mcomella added this to Needs prioritization in Performance, front-end roadmap via automation Jul 27, 2021
@mcomella mcomella moved this from Needs prioritization to In progress in Performance, front-end roadmap Jul 27, 2021
@mcomella mcomella changed the title [Bug]: SettingsPrivacyTest.launchLinksInPrivateToggleOffStateDoesntChangeTest fails locally on Pixel 2 [Bug]: SettingsPrivacyTest.launchLinksInPrivateToggleOffStateDoesntChangeTest fails locally on Pixel 2 (smaller screen devices?) Jul 27, 2021
mcomella added a commit to mcomella/fenix that referenced this issue Jul 27, 2021
@mcomella mcomella added needs:triage Issue needs triage and removed needs:triage Issue needs triage labels Jul 27, 2021
@mergify mergify bot closed this as completed in f7b85a6 Jul 28, 2021
Performance, front-end roadmap automation moved this from In progress to Done Jul 28, 2021
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage
Development

No branches or pull requests

1 participant