Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Native Dark Theme #208

Closed
yoasif opened this issue Jan 20, 2019 · 7 comments
Closed

Native Dark Theme #208

yoasif opened this issue Jan 20, 2019 · 7 comments
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:Themes Dark mode, light mode, private browsing mode

Comments

@yoasif
Copy link
Contributor

yoasif commented Jan 20, 2019

As a user, I want to select a browser theme that is dark so that it can match my default dark Android theme or differ from my default light theme.

Note - this feature is no longer part of Battery Saving and will need UX spec for settings

UX issue #826

Acceptance Criteria

I can allow Fenix to display the theme that matches my default Android theme
I will find enough visual contrast on both light and dark themes to meet a11y standards
I can change themes between dark and light

Why/User Benefit/User Problem

Many users would like a dark mode across their device, and Android now has a setting for this. This ideally would also apply to versions prior to Pie as well, as a setting option. See #209.

Android setting: https://www.cnet.com/how-to/how-to-enable-android-pies-new-dark-mode-and-save-battery-life-p/

Dark mode also has impacts on battery life (less power used): https://www.cnet.com/news/using-androids-dark-mode-improves-battery-life-google-confirms-p/

┆Issue is synchronized with this Jira Task

@owendaprile
Copy link

A dark mode should not only be pure black. There’s a lot of evidence out there against pure black backgrounds (https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/). OLED screens also benefit linearly in power reduction from white to black, so a gray background saves a lot of battery anyway. Any dark mode should be gray by default with pure black as an option.

@digitalcircuit
Copy link
Contributor

I'd like to reaffirm support for "pure black as an option" - some people use pure black for accessibility reasons, e.g. hypersensitivity to light. The linked article from @owendaprile mentions this under High Contrast for Accessibility.

Alternatively, Fenix could implement a dark theme in a way that's similar to the approach for desktop Firefox - open up every color to themes, so pure black could be a third-party addition.

@sprite-1
Copy link

I agree with the dark mode not be pure black by default. Some apps only offer that as their "dark mode" and the contrast is too much for me personally

@bbinto bbinto added the P4 label Jan 22, 2019
@bbinto bbinto added this to the Backlog milestone Jan 22, 2019
@bbinto bbinto added P3 Some future sprint and removed P4 labels Feb 19, 2019
@bbinto bbinto modified the milestones: Backlog, Milestone 3 Backlog Feb 20, 2019
@bbinto bbinto removed the P3 Some future sprint label Feb 20, 2019
@AmyYLee AmyYLee self-assigned this Mar 1, 2019
@bbinto
Copy link
Contributor

bbinto commented Mar 18, 2019

As per comment, we might pull this back into a Battery saving story after MVP, however it should land for MVP as an individual feature.

@vesta0 vesta0 changed the title Support for Pie Dark Mode Native Dark Theme Apr 2, 2019
@vesta0 vesta0 added access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:Themes Dark mode, light mode, private browsing mode P1 Current sprint labels Apr 2, 2019
@vesta0 vesta0 added the Epic label Apr 2, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 2, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 2, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 2, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 2, 2019
colintheshots pushed a commit that referenced this issue Apr 3, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 4, 2019
ekager added a commit to ekager/fenix that referenced this issue Apr 4, 2019
boek pushed a commit that referenced this issue Apr 5, 2019
@bifleming bifleming added this to In Progress in Fenix Sprint Kanban Apr 5, 2019
@ekager ekager moved this from In Progress to Ready for QA in Fenix Sprint Kanban Apr 8, 2019
@ekager ekager added the eng:qa:needed QA Needed label Apr 8, 2019
@bsurd
Copy link

bsurd commented Apr 17, 2019

This has been tested and verified by QA, removing the QA needed label but leaving the issue open until all blocking/related issues are fixed.

@bsurd bsurd removed the eng:qa:needed QA Needed label Apr 17, 2019
@bifleming
Copy link

@ekager

@kbrosnan
Copy link
Contributor

Blocking issue has been closed.

@vesta0 vesta0 removed the Epic label Apr 24, 2019
@vesta0 vesta0 closed this as completed Apr 24, 2019
@ghost ghost removed the P1 Current sprint label Apr 24, 2019
@vesta0 vesta0 moved this from Ready for QA to Done in Fenix Sprint Kanban Apr 24, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title Native Dark Theme FNX2-17644 ⁃ Native Dark Theme Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17644 ⁃ Native Dark Theme FNX3-16043 ⁃ Native Dark Theme Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16043 ⁃ Native Dark Theme FNX-5441 ⁃ Native Dark Theme Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5441 ⁃ Native Dark Theme Native Dark Theme May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:Themes Dark mode, light mode, private browsing mode
Projects
None yet
Development

No branches or pull requests