Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Separate tabs with the same search term into a different section #21236

Closed
jonalmeida opened this issue Sep 10, 2021 · 2 comments
Closed

Separate tabs with the same search term into a different section #21236

jonalmeida opened this issue Sep 10, 2021 · 2 comments
Assignees
@jonalmeida @rocketsroger
Labels
feature request 🌟 New functionality and improvements Feature:SearchTermTabs Tabs in the tabs tray that have the same search term. needs:triage Issue needs triage
Milestone
94

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Sep 10, 2021 •
edited by data-sync-user

JIRA link: https://mozilla-hub.atlassian.net/browse/FNXV2-17383

Acceptance Criteria

  • When I open my tabs tray, I see my active search term group(s) originated by the same search term visually separated. 
  • If a user already has a group for search term X and proceeds to search for X again and open new tabs from the search results, those tabs will be added to the original group.
  • The group only moves to INACTIVE when all the tabs in the group become inactive.
  • Order of groups will be based on creation date
  • Order of tabs within group will be based on creation date
  • User can disable groups in settings

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added feature request 🌟 New functionality and improvements Feature:SearchTermTabs Tabs in the tabs tray that have the same search term. labels Sep 10, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 10, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Sep 10, 2021
@rocketsroger
For mozilla-mobile#21236: Separate tabs with the same search term int…
cab9561 
…o a different section in tabs tray
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Sep 16, 2021
@jonalmeida
Issue mozilla-mobile#21236: Scroll to selected tab + various tab fixe…
41aba16 
…s for groupings
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Sep 16, 2021
@rocketsroger
Merge pull request #2 from jonalmeida/tabs_group
f3413ef 
Issue mozilla-mobile#21236: Scroll to selected tab + various tab fixes for groupings
jonalmeida added a commit to rocketsroger/fenix that referenced this issue Sep 16, 2021
@jonalmeida
Issue mozilla-mobile#21236: Fix failing test
2c6a941
jonalmeida pushed a commit to rocketsroger/fenix that referenced this issue Sep 16, 2021
@rocketsroger @jonalmeida
For mozilla-mobile#21236: Separate tabs with the same search term int…
382f3d0 
…o a different section in tabs tray
jonalmeida added a commit to rocketsroger/fenix that referenced this issue Sep 16, 2021
@jonalmeida
Issue mozilla-mobile#21236: Scroll to selected tab + various tab fixe…
122e3e4 
…s for groupings
jonalmeida added a commit to rocketsroger/fenix that referenced this issue Sep 16, 2021
@jonalmeida
Issue mozilla-mobile#21236: Fix failing test
f64cc98
jonalmeida added a commit to rocketsroger/fenix that referenced this issue Sep 17, 2021
@jonalmeida
Issue mozilla-mobile#21236: Fix failing test
1ff6bc0
jonalmeida pushed a commit to rocketsroger/fenix that referenced this issue Sep 17, 2021
@rocketsroger @jonalmeida
For mozilla-mobile#21236: Separate tabs with the same search term int…
2cf08e4 
…o a different section in tabs tray
jonalmeida added a commit to rocketsroger/fenix that referenced this issue Sep 17, 2021
@jonalmeida
Issue mozilla-mobile#21236: Scroll to selected tab + various tab fixe…
3da19d4 
…s for groupings
jonalmeida added a commit to rocketsroger/fenix that referenced this issue Sep 17, 2021
@jonalmeida
Issue mozilla-mobile#21236: Fix failing test
d998a61
mergify bot pushed a commit that referenced this issue Sep 17, 2021
@rocketsroger @jonalmeida
For #21236: Separate tabs with the same search term into a different …
fc18fd2 
…section (#21177)

* For #21236: Separate tabs with the same search term into a different section in tabs tray

* Issue #21236: Scroll to selected tab + various tab fixes for groupings

* Issue #21236: Fix failing test

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
@jonalmeida jonalmeida added this to the 94 milestone Sep 17, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 17, 2021
@rocketsroger @jonalmeida @pkirakosyan
For mozilla-mobile#21236: Separate tabs with the same search term int…
7b321a0 
…o a different section (mozilla-mobile#21177)

* For mozilla-mobile#21236: Separate tabs with the same search term into a different section in tabs tray

* Issue mozilla-mobile#21236: Scroll to selected tab + various tab fixes for groupings

* Issue mozilla-mobile#21236: Fix failing test

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Sep 17, 2021
@jonalmeida @rocketsroger
Issue mozilla-mobile#21236: Fixes empty tray visibility logic
2c84385 
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Sep 17, 2021
@jonalmeida @rocketsroger
Issue mozilla-mobile#21236: Fixes empty tray visibility logic
77b67fc 
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
jonalmeida added a commit that referenced this issue Sep 17, 2021
@jonalmeida @rocketsroger
Issue #21236: Fixes empty tray visibility logic
bc7f5d8 
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
@bb010g
Copy link

bb010g commented Sep 19, 2021

Discussion of the usability of this feature is occurring in #21360.

pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 24, 2021
@jonalmeida @rocketsroger @pkirakosyan
Issue mozilla-mobile#21236: Fixes empty tray visibility logic
0cf5fe3 
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
@jonalmeida
Copy link
Contributor Author

Closing as completed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

@rocketsroger rocketsroger

Labels
feature request 🌟 New functionality and improvements Feature:SearchTermTabs Tabs in the tabs tray that have the same search term. needs:triage Issue needs triage
Projects
None yet
Milestone
94
Development

No branches or pull requests
3 participants
@bb010g @jonalmeida @rocketsroger