Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Intermittent FenixSnackbarKtTest.WHEN anchorWithAction is called THEN correct text will be set #21335

Closed
mcomella opened this issue Sep 16, 2021 · 0 comments
Closed

Intermittent FenixSnackbarKtTest.WHEN anchorWithAction is called THEN correct text will be set #21335

mcomella opened this issue Sep 16, 2021 · 0 comments
Assignees
@mcomella
Projects
Performance, front-end roadmap

Comments

@mcomella
Copy link
Contributor

mcomella commented Sep 16, 2021 •
edited by data-sync-user

From https://github.com/mozilla-mobile/fenix/pull/21311/checks?check_run_id=3612142760 / https://firefoxci.taskcluster-artifacts.net/WyJZUb7RSCuHLQ6bG9BN9w/0/public/reports/test/testDebugUnitTest/index.html.

THis looks like the mocking lambdas thing.

java.lang.InstantiationError: kotlin.jvm.functions.Function0
	at jdk.internal.reflect.GeneratedSerializationConstructorAccessor216.newInstance(Unknown Source)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:48)
...
at io.mockk.MockKKt.every(MockK.kt:98)
	at org.mozilla.fenix.tabstray.ext.FenixSnackbarKtTest.WHEN anchorWithAction is called THEN correct text will be set(FenixSnackbarKtTest.kt:77)

┆Issue is synchronized with this Jira Task
@mcomella mcomella self-assigned this Sep 16, 2021
@mcomella mcomella added this to Needs triage in Performance, front-end roadmap via automation Sep 16, 2021
@mcomella mcomella moved this from Needs triage to In progress in Performance, front-end roadmap Sep 16, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 16, 2021
@mcomella mcomella mentioned this issue Sep 16, 2021
Merged
3 tasks
mcomella added a commit to mcomella/fenix that referenced this issue Sep 16, 2021
@mcomella
Closes mozilla-mobile#21335: return self instead of mock in FenixSnac…
9adf631 
…kbarKtTest.

This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.

Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.
mcomella added a commit to mcomella/fenix that referenced this issue Sep 16, 2021
@mcomella
Closes mozilla-mobile#21335: return self instead of mock in FenixSnac…
9c6fbf7 
…kbarKtTest.

This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.

Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.

See b3f5c87 for a prior attempt to
address the intermittents in this class.
@mcomella mcomella removed the needs:triage Issue needs triage label Sep 16, 2021
@mergify mergify bot closed this as completed in a3d3519 Sep 17, 2021
Performance, front-end roadmap automation moved this from In progress to Done Sep 17, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Sep 24, 2021
@mcomella @pkirakosyan
Closes mozilla-mobile#21335: return self instead of mock in FenixSnac…
0a8b374 
…kbarKtTest.

This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.

Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.

See b3f5c87 for a prior attempt to
address the intermittents in this class.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
None yet
Projects
Performance, front-end roadmap
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcomella