This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
HomeFragment is unexpectedly inflated on cold VIEW start up (was: 39-127ms COLD VIEW start up regression around 10/1) #21759
Labels
Comments
What we're seeing here is that the execution time of |
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 7, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo
added a commit
to csadilek/fenix
that referenced
this issue
Oct 8, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 8, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 14, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 15, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 15, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 18, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Oct 18, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Dec 2, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
csadilek
added a commit
to csadilek/fenix
that referenced
this issue
Dec 2, 2021
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
The day after the PR #21805 landed, we measured an improvement of ~138ms to our COLD VIEW start up numbers. 🎉 This is similar to what I measured in my proof-of-concept measuring; #21805 (comment) |
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this issue
Mar 8, 2022
…ng to tab Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
This is a breakout from #21749.
We see a regression between 9/29 and 10/1:
The regression continues to rise. From 9/29 to 10/5, we see a regression of:
VIEW (note the scales are different):
![image](https://user-images.githubusercontent.com/759372/136269040-7ddb6561-87f4-4154-97fd-93bac08e663c.png)
This seems like it could be be two discrete regressions – one between 9/29 & 10/1 and one on 10/5. Dashboard link. The numbers seem a little noisy so let me know if you think it's worth retaking them. Maybe we should start with a profile though.
Profiles
VIEW:
One notable visual difference between these builds is the inclusion of Pocket content. There was also an update the synchronized the layouts for the homescreen. These could be the two events I mentioned above. However, this shouldn't affect the VIEW code path: let's find out what's going on.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: