Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove duplicate icons that already exists in ui-icons #23121

Closed
gabrielluong opened this issue Jan 8, 2022 · 0 comments · Fixed by #23313
Closed

Remove duplicate icons that already exists in ui-icons #23121

gabrielluong opened this issue Jan 8, 2022 · 0 comments · Fixed by #23313
Assignees
@gabrielluong
Projects
Android Engineering Team Kanban board
Milestone
98

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jan 8, 2022 •
edited by data-sync-user

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Jan 8, 2022
@gabrielluong gabrielluong added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jan 8, 2022
@gabrielluong gabrielluong moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jan 8, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 8, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jan 8, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawable/ic_addons_extensions wit…
a1b724a 
…h @drawable/mozac_ic_extensions
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replalce @drawable/ic_new witth @drawable/…
e13bfac 
…mozac_ic_new
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawable/ic_arrowhead_right with …
9fc6d64 
…@drawable/mozac_ic_arrowhead_right
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_back_button with @draw…
b6a9832 
…able/mozac_ic_back
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_chevron_down with @dra…
5f8beac 
…wable/mozac_ic_arrowhead_down
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_chevron_up with @drawa…
d0ace12 
…ble/mozac_ic_arrowhead_up
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_delete with @drawable/…
0388535 
…mozac_ic_delete
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_close with @drawable/m…
4c89341 
…ozac_ic_close
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_desktop with @drawable…
21d258c 
…/mozac_ic_device_desktop
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_lock with @drawable/mo…
27e74a3 
…zac_ic_lock
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_download with @drawabl…
bcdbdb6 
…e/mozac_ic_download
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_internet with @drawabl…
d76ae21 
…e/mozac_ic_globe
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_login with @drawable/m…
964eef7 
…ozac_ic_login
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_menu with @drawable/mo…
cec652a 
…zac_ic_menu
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_readermode with @drawa…
224dd23 
…ble/mozac_ic_reader_mode
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_search with @drawable/…
719d87e 
…mozac_ic_search
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_top_sites with @drawab…
4bedb1b 
…le/mozac_ic_pin
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/mozac_ic_extensions_black…
d665b02 
… with @drawable/mozac_ic_extensions
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_camera_enabled with @d…
d89c4c7 
…rawable/mozac_ic_video
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_autoplay_disabled with…
50c7436 
… @drawable/mozac_ic_autoplay_blocked
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_location_enabled with …
c4c95c6 
…@drawable/mozac_ic_location
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_microphone_enabled wit…
d749ed6 
…h @drawable/mozac_ic_microphone
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_notifications_enabled …
8f4f631 
…with @drawable/mozac_ic_notification
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_storage_enabled with @…
0dcd448 
…drawable/mozac_ic_storage
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 20, 2022
@gabrielluong
For mozilla-mobile#23121 - Replace @drawble/ic_share with @drawable/m…
d0f618e 
…ozac_ic_share
gabrielluong added a commit that referenced this issue Feb 1, 2022
@gabrielluong
Revert "For #23121 - Replace @drawable/ic_addons_extensions with @dra…
5dc6222 
…wable/mozac_ic_extensions"

This reverts commit 9352946.
mergify bot pushed a commit that referenced this issue Feb 1, 2022
@gabrielluong
For #23350 - Revert changes from removing duplicate icons that alread…
39c6067 
…y exists in ui-icons (#23527)

* Revert "For #23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"

This reverts commit 12347c9.

* Revert "For #23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"

This reverts commit bbf6ce3.

* Revert "For #23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"

This reverts commit 930c7bf.

* Revert "For #23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"

This reverts commit 9069b57.

* Revert "For #23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"

This reverts commit 53216f3.

* Revert "For #23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"

This reverts commit 9ee9aaf.

* Revert "For #23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"

This reverts commit b045a5e.

* Revert "For #23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"

This reverts commit 62842db.

* Revert "For #23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"

This reverts commit c020a9d.

* Revert "For #23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"

This reverts commit ca67b0a.

* Revert "For #23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"

This reverts commit 02d9197.

* Revert "For #23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"

This reverts commit cf8592c.

* Revert "For #23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"

This reverts commit a1ac019.

* Revert "For #23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"

This reverts commit 541c56b.

* Revert "For #23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"

This reverts commit 4d8adce.

* Revert "For #23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"

This reverts commit ef026d3.

* Revert "For #23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"

This reverts commit 18591d5.

* Revert "For #23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"

This reverts commit ad33e3c.

* Revert "For #23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"

This reverts commit a9f0fef.

* Revert "For #23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"

This reverts commit 33dc752.

* Revert "For #23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"

This reverts commit 5bf937c.

* Revert "For #23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"

This reverts commit 0fadd68.

* Revert "For #23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"

This reverts commit bea766e.

* Revert "For #23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"

This reverts commit 5a6f349.

* Revert "For #23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"

This reverts commit ae38410.

* Revert "For #23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"

This reverts commit 9352946.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawable/ic_addons_extensions wit…
29a9f3d 
…h @drawable/mozac_ic_extensions
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawable/ic_new with @drawable/mo…
e7f7d71 
…zac_ic_new
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawable/ic_arrowhead_right with …
c2e3de9 
…@drawable/mozac_ic_arrowhead_right
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_back_button with @draw…
c9312ac 
…able/mozac_ic_back
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_chevron_down with @dra…
4abf411 
…wable/mozac_ic_arrowhead_down
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_chevron_up with @drawa…
3814864 
…ble/mozac_ic_arrowhead_up
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_delete with @drawable/…
054e34a 
…mozac_ic_delete
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_close with @drawable/m…
26843f2 
…ozac_ic_close
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_desktop with @drawable…
db00cd5 
…/mozac_ic_device_desktop
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_lock with @drawable/mo…
651ff44 
…zac_ic_lock
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_download with @drawabl…
5bbef6c 
…e/mozac_ic_download
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_internet with @drawabl…
4d993e2 
…e/mozac_ic_globe
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_login with @drawable/m…
36a7b0d 
…ozac_ic_login
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_menu with @drawable/mo…
5039e59 
…zac_ic_menu
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_readermode with @drawa…
e270d7b 
…ble/mozac_ic_reader_mode
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_search with @drawable/…
933526f 
…mozac_ic_search
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_top_sites with @drawab…
a543890 
…le/mozac_ic_pin
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/mozac_ic_extensions_black…
3735e09 
… with @drawable/mozac_ic_extensions
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_camera_enabled with @d…
4402aec 
…rawable/mozac_ic_video
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_autoplay_disabled with…
c0f2204 
… @drawable/mozac_ic_autoplay_blocked
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_location_enabled with …
9d3cb0a 
…@drawable/mozac_ic_location
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_microphone_enabled wit…
d4995d9 
…h @drawable/mozac_ic_microphone
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_notifications_enabled …
3a54ecd 
…with @drawable/mozac_ic_notification
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_storage_enabled with @…
8e4507c 
…drawable/mozac_ic_storage
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Replace @drawble/ic_share with @drawable/m…
00a46fb 
…ozac_ic_share
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23121 - Override @color/mozac_ui_icons_fill with ?…
c14cd44 
…primaryText attribute
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 10, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23350 - Revert changes from removing duplicate ico…
b632c86 
…ns that already exists in ui-icons (mozilla-mobile#23527)

* Revert "For mozilla-mobile#23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"

This reverts commit 12347c9.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"

This reverts commit bbf6ce3.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"

This reverts commit 930c7bf.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"

This reverts commit 9069b57.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"

This reverts commit 53216f3.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"

This reverts commit 9ee9aaf.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"

This reverts commit b045a5e.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"

This reverts commit 62842db.

* Revert "For mozilla-mobile#23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"

This reverts commit c020a9d.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"

This reverts commit ca67b0a.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"

This reverts commit 02d9197.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"

This reverts commit cf8592c.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"

This reverts commit a1ac019.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"

This reverts commit 541c56b.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"

This reverts commit 4d8adce.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"

This reverts commit ef026d3.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"

This reverts commit 18591d5.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"

This reverts commit ad33e3c.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"

This reverts commit a9f0fef.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"

This reverts commit 33dc752.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"

This reverts commit 5bf937c.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"

This reverts commit 0fadd68.

* Revert "For mozilla-mobile#23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"

This reverts commit bea766e.

* Revert "For mozilla-mobile#23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"

This reverts commit 5a6f349.

* Revert "For mozilla-mobile#23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"

This reverts commit ae38410.

* Revert "For mozilla-mobile#23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"

This reverts commit 9352946.
@gabrielluong gabrielluong mentioned this issue Jul 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
None yet
Projects
No open projects
Android Engineering Team Kanban board
Done
Milestone
98
Development

Successfully merging a pull request may close this issue.

For #23121 - Remove duplicate icons that already exists in ui-icons gabrielluong/fenix
2 participants
@kbrosnan @gabrielluong