Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Send crash reports to Glean #235

Closed
pocmo opened this issue Mar 20, 2018 · 17 comments
Closed

Send crash reports to Glean #235

pocmo opened this issue Mar 20, 2018 · 17 comments

Comments

@pocmo
Copy link
Contributor

pocmo commented Mar 20, 2018

Why/User Benefit/User Problem

Crash pings would help us to calculate crash rates... something we do not get with Sentry (#2326).

Fennec implementation:
https://bugzilla.mozilla.org/show_bug.cgi?id=1407557

This is something we'd implement in the telemetry library:
https://github.com/mozilla-mobile/telemetry-android

What/Requirements

Add Glean crash reporter to CrashReporter services.

https://github.com/mozilla-mobile/android-components/tree/master/components/lib/crash#sending-crash-reports-to-glean

Acceptance Criteria (how do I know when I’m done?)

  • Glean Crash reporter is added, and crash counts are being sent
  • Documentation added to Fenix telemetry docs, explaining what the crash reporter collects
  • Data review for adding new telemetry collection of Glean crash reporter

┆Issue is synchronized with this Jira Task

@daoshengmu
Copy link

I am curious if we already have the crash pings in Fennec that means Gecko can send the crash pings to the telemetry server (http://telemetry.mozilla.org/). So, what is the following work for android-telemetry-components? IIUC, the crash pings from Gecko could help us catch the crashes from the Gecko side, like Gecko View.

@vesta0
Copy link
Collaborator

vesta0 commented Nov 14, 2018

No longer relevant considering sentry and crash reporting (discussed in triage)

@vesta0 vesta0 closed this as completed Nov 14, 2018
@Sdaswani Sdaswani transferred this issue from mozilla-mobile/focus-android Jan 22, 2019
@Sdaswani Sdaswani reopened this Jan 22, 2019
@bbinto
Copy link
Contributor

bbinto commented Feb 5, 2019

Is this still a valid issues? If so, we are aiming for crash reporting / good stats for milestone 2 or 3, so feel free to size during triage AND move it into milestone 2 backlog.

@pocmo
Copy link
Contributor Author

pocmo commented Feb 5, 2019

Yes, this is still valid. The crash ping will help us to measure the health of the app and hopefully avoid situations like we had in Focus where we couldn't really pinpoint certain issues.

The glean, app and AC teams have met and are going to work on a solution to collect this data with Glean from the crash reporter component.

In AC that is tracked by the meta "Good crash statistics":
mozilla-mobile/android-components#1820

The related Glean issue is:
https://bugzilla.mozilla.org/show_bug.cgi?id=1522461

@vesta0 vesta0 added this to the MVP Backlog milestone Apr 1, 2019
@vesta0 vesta0 added P2 Upcoming release P1 Current sprint and removed P2 Upcoming release labels Apr 1, 2019
@vesta0 vesta0 changed the title Consider using crash pings Integrate crash pings Apr 3, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 9, 2019

@bbinto please advise.

@bbinto
Copy link
Contributor

bbinto commented Apr 10, 2019

@pocmo can you help me understand what work is left to do for the A-C team, and Fenix, and do you have everything you need from the Glean team to send this ping?

If we don't get any update on this before sprint planning, I'm fine with moving this down the backlog for now.

/cc @vesta0

@vesta0 vesta0 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 11, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 11, 2019

@vesta0 vesta0 added P2 Upcoming release and removed P1 Current sprint labels Apr 11, 2019
@bifleming bifleming added this to Blocked by Glean in Blocking Fenix Apr 17, 2019
@bifleming bifleming modified the milestones: MVP Backlog, Dev Stories Backlog May 2, 2019
@vesta0 vesta0 added P1 Current sprint and removed P2 Upcoming release labels May 24, 2019
@bifleming bifleming added this to Blocked by Unknown in Blocking Fenix Jun 7, 2019
@bifleming bifleming added this to Blocked by Other in Fenix: A-S Bugs Jun 12, 2019
@bifleming bifleming moved this from Unnassigned to Release to Blocked items needed for Fenix Q3 in Fenix: A-S Bugs Jun 27, 2019
@boek boek removed this from the Dev Stories Backlog milestone Jul 17, 2019
liuche added a commit to liuche/fenix that referenced this issue Sep 24, 2019
liuche added a commit to liuche/fenix that referenced this issue Sep 24, 2019
liuche added a commit to liuche/fenix that referenced this issue Sep 24, 2019
@liuche liuche moved this from In Progress to In Review in Fenix Sprint Kanban Sep 26, 2019
@liuche liuche modified the milestones: v2.1, v2.2 Sep 26, 2019
sblatz pushed a commit to liuche/fenix that referenced this issue Sep 27, 2019
sblatz pushed a commit to liuche/fenix that referenced this issue Sep 27, 2019
sblatz pushed a commit to liuche/fenix that referenced this issue Sep 27, 2019
sblatz pushed a commit that referenced this issue Sep 30, 2019
@liuche
Copy link
Contributor

liuche commented Sep 30, 2019

This unblocks #5113, which has a bugzilla bug.

@sblatz
Copy link
Contributor

sblatz commented Sep 30, 2019

@liuche Should I put a QA needed on this?

sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
@liuche
Copy link
Contributor

liuche commented Sep 30, 2019

Don't need a QA-label here - we'll wait for the dashboard #5113, which should be the verification. I'll close this then.

@liuche liuche closed this as completed Sep 30, 2019
Fenix Sprint Kanban automation moved this from In Dev Review to (DO NOT USE) Done Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
@sblatz sblatz moved this from (DO NOT USE) Done to Sprint 10.1 Done in Fenix Sprint Kanban Oct 1, 2019
@data-sync-user data-sync-user changed the title Send crash reports to Glean FNX2-17922 ⁃ Send crash reports to Glean Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17922 ⁃ Send crash reports to Glean FNX3-16251 ⁃ Send crash reports to Glean Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16251 ⁃ Send crash reports to Glean FNX-5609 ⁃ Send crash reports to Glean Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5609 ⁃ Send crash reports to Glean Send crash reports to Glean May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Blocking Fenix
Blocked by Other
Development

No branches or pull requests