Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Onboarding - Custom Setting Card: Choose Theme #2389

Closed
mheubusch opened this issue May 9, 2019 · 2 comments
Closed

Onboarding - Custom Setting Card: Choose Theme #2389

mheubusch opened this issue May 9, 2019 · 2 comments
Assignees
@ekager
Labels
Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR P1 Current sprint Release Blocker Blocks a Release
Milestone
Sprint 5-2 (Miles...

Comments

@mheubusch
Copy link
Contributor

mheubusch commented May 9, 2019 •
edited by data-sync-user
Loading

As a user who views a custom setting card for choice of themes, I want to be able to keep my current theme or select a new one within the onboarding flow.

Dependencies

  • List dependencies on other issues/teams etc.

Acceptance Criteria

  • I can do nothing and will still have the light theme
  • I can select the dark theme and see the app switch to the dark theme
  • I can choose to have my theme match my device theme, and have the light theme persist if i am using device light theme or switch to the dark theme if I am using device dark theme
  • I will remain within the onboarding context while I make changes to the theme and can access the theme choices until the onboarding flow is dismissed

┆Issue is synchronized with this Jira Task
@mheubusch mheubusch added the Epic label May 9, 2019
@mheubusch mheubusch changed the title Onboarding - Choose Theme Onboarding - Custom Setting Card: Choose Theme May 9, 2019
@sblatz sblatz added Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR and removed Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR labels May 9, 2019
@bifleming bifleming added this to the Sprint 5-2 (Milestone 5) milestone May 9, 2019
@bifleming bifleming added this to Ready for Dev in Fenix Sprint Kanban May 9, 2019
@ekager ekager self-assigned this May 16, 2019
ekager added a commit to ekager/fenix that referenced this issue May 17, 2019
@ekager
For mozilla-mobile#2389 - Create Theme Onboarding Card
33ec8b7
@vesta0 vesta0 added the P1 Current sprint label May 17, 2019
@vesta0 vesta0 moved this from Ready for Dev to In Progress in Fenix Sprint Kanban May 17, 2019
ekager added a commit to ekager/fenix that referenced this issue May 18, 2019
@ekager
For mozilla-mobile#2389 - Create Theme Onboarding Card
3c1f14f
ekager added a commit that referenced this issue May 20, 2019
@ekager
For #2389 - Create Theme Onboarding Card
d347f73
@ekager ekager moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 20, 2019
boek added a commit to boek/fenix that referenced this issue May 21, 2019
@boek
For mozilla-mobile#2389 - Save state on homeview when switching themes
6cb632b
boek added a commit to boek/fenix that referenced this issue May 21, 2019
@boek
For mozilla-mobile#2389 - Save state on homeview when switching themes
2ebe33a
boek added a commit that referenced this issue May 21, 2019
@boek
For #2389 - Save state on homeview when switching themes
9a76c11
@ekager ekager added the eng:qa:needed QA Needed label May 23, 2019
@lobontiumira
Copy link

I will remove the QA needed flag until #2721 is fixed.

@lobontiumira lobontiumira added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed eng:qa:needed QA Needed labels May 27, 2019
@ekager ekager mentioned this issue May 28, 2019
Closed
@lobontiumira lobontiumira removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 29, 2019
@lobontiumira
Copy link

I will close this issue, hence #2721 is fixed.

@lobontiumira lobontiumira moved this from Ready for QA to Done in Fenix Sprint Kanban May 29, 2019
@data-sync-user data-sync-user changed the title Onboarding - Custom Setting Card: Choose Theme FNX2-17952 ⁃ Onboarding - Custom Setting Card: Choose Theme Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-17952 ⁃ Onboarding - Custom Setting Card: Choose Theme FNX3-16283 ⁃ Onboarding - Custom Setting Card: Choose Theme Aug 11, 2020
@ekager ekager closed this as completed Aug 17, 2020
@data-sync-user data-sync-user changed the title FNX3-16283 ⁃ Onboarding - Custom Setting Card: Choose Theme Onboarding - Custom Setting Card: Choose Theme May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR P1 Current sprint Release Blocker Blocks a Release
Projects
None yet
Milestone
Sprint 5-2 (Milestone 5)
Development

No branches or pull requests
7 participants
@sblatz @mheubusch @ekager @lobontiumira @vesta0 @bifleming @data-sync-user