Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Let A-C handle toolbar expanding when URL changes #25455

Closed
Mugurell opened this issue May 31, 2022 · 4 comments
Closed

Let A-C handle toolbar expanding when URL changes #25455

Mugurell opened this issue May 31, 2022 · 4 comments
Assignees
@indurs
Labels
eng:health Improve code health eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search

Comments

@Mugurell
Copy link
Contributor

Mugurell commented May 31, 2022 •
edited by data-sync-user

mozilla-mobile/android-components#12215 would upstream the current behavior to A-C for Focus to also automatically have the toolbar expanded when the URL changes.

We'd need to remove the now duplicated toolbar expanding functionality from Fenix but ensure the find in page bar is still hidden from Fenix when the url changes.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added eng:health Improve code health Feature:Toolbar Address bar, see also Feature:Search labels May 31, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label May 31, 2022
@Mugurell Mugurell removed the needs:triage Issue needs triage label May 31, 2022
This was referenced May 31, 2022
Closed
Merged
Closed
indurs added a commit to indurs/fenix that referenced this issue May 31, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
99dee23 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@Mugurell
Copy link
Contributor Author

Thank you for taking this @indurs .
I cannot add you as the assignee though until you having a comment on this ticket.

@indurs
Copy link
Contributor

indurs commented May 31, 2022

@Mugurell , can I work on this issue?

indurs added a commit to indurs/fenix that referenced this issue Jun 1, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
9ef6d7c 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
indurs added a commit to indurs/fenix that referenced this issue Jun 1, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
86f09f2 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
indurs added a commit to indurs/fenix that referenced this issue Jun 6, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
b7c2d8a 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
indurs added a commit to indurs/fenix that referenced this issue Jun 6, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
4a0092f 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
indurs added a commit to indurs/fenix that referenced this issue Jun 6, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
8b9ea52 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
Mugurell added a commit to indurs/fenix that referenced this issue Jun 7, 2022
@indurs @Mugurell
For mozilla-mobile#25455 : Let A-C handle toolbar expanding when URL …
d1df37c 
…changes

This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
Mugurell added a commit that referenced this issue Jun 7, 2022
@indurs @Mugurell
For #25455 : Let A-C handle toolbar expanding when URL changes
ac31a1a 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@Mugurell Mugurell added the eng:qa:needed QA Needed label Jun 7, 2022
@Mugurell
Copy link
Contributor Author

Mugurell commented Jun 7, 2022

@ QA: This ticket was about refactoring code, please ensure the app functions the same as before with the toolbar being shown when the page is loading.
Changes are similar to mozilla-mobile/focus-android#7140.

@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox nightly 103.0a1 2022-06-08 and the toolbar is being shown when a page is loading.

Devices used:

  • Google Pixel 6 (Android 13)
  • OnePlus 6T (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@indurs indurs

Labels
eng:health Improve code health eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mugurell @indurs @LaurentiuApahideanSV