Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Missing content SUMO page for TCP #26956

Closed
AdinaPetridean opened this issue Sep 13, 2022 · 10 comments
Closed

[Bug]: Missing content SUMO page for TCP #26956

AdinaPetridean opened this issue Sep 13, 2022 · 10 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage S4 Minor significance, cosmetic issues, low or no impact to users TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368

Comments

@AdinaPetridean
Copy link

AdinaPetridean commented Sep 13, 2022

Steps to reproduce

  1. Perform a Clear Data.
  2. Visit a webpage and observe the TCP CFR displayed above the toolbar.
  3. Tap the hyperlink in the CFR.
  4. Observe the SUMO page opened.

Expected behaviour.

The content on the https://support.mozilla.org/1/mobile/%25VERSION%25/%25OS%25/%25LOCALE%25/enhanced-tracking-protection-android SUMO page is displayed.

Actual behaviour

The content is missing and the "Page no found" error is displayed.

Device name

Xiaomi Pad5

Android version

Android 11

Firefox release type

Firefox Nightly

Firefox version

Firefox Nightly 106.0a1 - 09/13

Device logs

No response

Additional information

┆Issue is synchronized with this Jira Task

@AdinaPetridean AdinaPetridean added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage S4 Minor significance, cosmetic issues, low or no impact to users TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368 labels Sep 13, 2022
@kbrosnan
Copy link
Contributor

kbrosnan commented Sep 13, 2022

SUMO will release the page when it gets closer to the release.

@kbrosnan kbrosnan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2022
@cpeterso
Copy link

cpeterso commented Nov 4, 2022

The updated SUMO is now live. The Total Cookie Protection section is only visible for visitors with Firefox >= 107.

https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android#mobile::m107

@cpeterso
Copy link

cpeterso commented Nov 4, 2022

Oops. I see the problem is that the CFR points to a different URL path:

CFR: /kb/enhanced-tracking-protection-android
Actual page: /kb/enhanced-tracking-protection-firefox-android

It's probably too late to update the CFR code, so I will ask the SUMO team if they can add a page redirect from enhanced-tracking-protection-android to /kb/enhanced-tracking-protection-firefox-android.

@cpeterso cpeterso reopened this Nov 4, 2022
@cpeterso
Copy link

cpeterso commented Nov 4, 2022

Reopening. Even if the SUMO team adds a redirect, we should fix the URL in the CFR code so we can remove the redirect later.

@cpeterso
Copy link

cpeterso commented Nov 8, 2022

The SUMO redirect from the TCP CFR's URL https://support.mozilla.org/kb/enhanced-tracking-protection-android to the article's URL https://support.mozilla.org/kb/enhanced-tracking-protection-firefox-android is now live.

Ryan Johnson on SUMO team recommends that we replace the TCP CFR's SUMO URL with an "in-product" link. I'm waiting for more details from Ryan.

@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 14, 2022
@Mugurell
Copy link
Contributor

Mugurell commented Nov 14, 2022

@cpeterso @DreVla Just added added a patch that would directly open https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android.
But it seems like in this case the inproduct param is missing - while it is automatically added in the redirect process for the old link - https://support.mozilla.org/1/mobile/108.0a1/Android/en-US/enhanced-tracking-protection-android (it works if clicked from here also).
https://support.mozilla.org/1/mobile/108.0a1/Android/en-US/enhanced-tracking-protection-firefox-android doesn't seem to exist.
Can we get the full URL to use?

For reference this is the link previously received from SUMO - https://support.mozilla.org/1/mobile/%25VERSION%25/%25OS%25/%25LOCALE%25/enhanced-tracking-protection-android (Jira specs) - currently used in the app.

@cpeterso
Copy link

@Mugurell Sorry this has gotten so confusing. I had to ask the SUMO web engineer to explain the difference to me.

He says the Fenix code should use https://support.mozilla.org/1/mobile/%25VERSION%25/%25OS%25/%25LOCALE%25/enhanced-tracking-protection-android

Note that this URL uses enhanced-tracking-protection-android (without "firefox"), even though the SUMO article's URL includes "firefox" like https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android! That is OK.

Example:

https://support.mozilla.org/1/mobile/%25VERSION%25/%25OS%25/%25LOCALE%25/enhanced-tracking-protection-android will be converted to https://support.mozilla.org/1/mobile/108.0a1/android/en-US/enhanced-tracking-protection-android, which SUMO will redirect to the real page https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android.

@Mugurell
Copy link
Contributor

Mugurell commented Nov 15, 2022

@Mugurell Sorry this has gotten so confusing. I had to ask the SUMO web engineer to explain the difference to me.

He says the Fenix code should use https://support.mozilla.org/1/mobile/%25VERSION%25/%25OS%25/%25LOCALE%25/enhanced-tracking-protection-android

Note that this URL uses enhanced-tracking-protection-android (without "firefox"), even though the SUMO article's URL includes "firefox" like https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android! That is OK.

It's great that we got the full URL to use.

What the SUMO team provided now

https://support.mozilla.org/1/mobile/%25VERSION%25/%25OS%25/%25LOCALE%25/enhanced-tracking-protection-android

is exactly what we got before (Jira specs)

https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/enhanced-tracking-protection-android

and what is currently used in the app and also the link from the original comment of this ticket:

TOTAL_COOKIE_PROTECTION("enhanced-tracking-protection-android"),

 
So it seems like there is no update needed.
When this ticket was opened the SUMO page wasn't up.
It seems that in this time it got published with the right content and users can access the intended URL by tapping the link in the CFR.

@cpeterso
Copy link

So it seems like there is no update needed.
When this ticket was opened the SUMO page wasn't up.
It seems that in this time it got published with the right content and users can access the intended URL by tapping the link in the CFR.

I'm glad no code change is needed after all. In that case, I'll close this bug.

The app's in-product URL ("enhanced-tracking-protection-android") wasn't working last week, even though the ETP SUMO article was up. I guess the SUMO team didn't point the in-product URL to the real SUMO article until I ask them about redirects last week.

@github-actions github-actions bot reopened this Nov 15, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 15, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 109.0a1 (2022-11-17) build.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage S4 Minor significance, cosmetic issues, low or no impact to users TaskContinuity https://mozilla-hub.atlassian.net/browse/FNXV2-19368
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants