Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix auto publish instructions for new Android Components location #27652

Closed
fice-t opened this issue Nov 1, 2022 · 7 comments · Fixed by #27665, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Labels
needs:triage Issue needs triage

Comments

@fice-t
Copy link
Contributor

fice-t commented Nov 1, 2022

The README contains the following:

In local.properties, specify a relative path to your local android-components and/or application-services checkouts. E.g.:

autoPublish.android-components.dir=../android-components

After the repo migration, using ../firefox-android results in:

python: can't open file '...StudioProjects/firefox-android/automation/publish_to_maven_local_if_modified.py': [Errno 2] No such file or directory

Using ../firefox-android/android-components results in:

Error: This only works if run from the repo root

CC @csadilek

┆Issue is synchronized with this Jira Task
┆Link To Issue: https://mozilla-hub.atlassian.net/browse/FNXV2-21911

@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 1, 2022
@jonalmeida
Copy link
Contributor

@fice-t can you try ../firefox-android/android-components? Does that still work?

@fice-t
Copy link
Contributor Author

fice-t commented Nov 1, 2022

@jonalmeida That's the 2nd case above (Error: This only works if run from the repo root).

@fice-t
Copy link
Contributor Author

fice-t commented Nov 1, 2022

This may be related (as the python script checks for existence of LICENSE file): mozilla-mobile/firefox-android@f304fcb

EDIT: Confirmed that reverting the above commit fixes this. Perhaps the find_project_root procedure should check for something else? Or just assume that the script is located in <android-components>/automation?

@fice-t
Copy link
Contributor Author

fice-t commented Nov 1, 2022

In any case, the Fenix README should be updated to ../firefox-android/android-components to reflect the migration, assuming this repo stays separated for long enough.

@csadilek
Copy link
Contributor

csadilek commented Nov 2, 2022

Confirmed that reverting the above commit fixes this. Perhaps the find_project_root procedure should check for something else? Or just assume that the script is located in /automation?

Thanks for filing, and good find @fice-t! If you have a working version locally, we'd appreciate a PR. If not, I will try to get to this soon. It's worth addressing before the repos are integrated.

@csadilek
Copy link
Contributor

csadilek commented Nov 2, 2022

Or just assume that the script is located in /automation?

Yes, I like that better than looking for LICENSE. I don't see why the location has to be more flexible.

@csadilek
Copy link
Contributor

csadilek commented Nov 2, 2022

See also mozilla-mobile/firefox-android#79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.