Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Forward and back button don't have visually disabled state in Dark Theme #3087

Closed
Scripterr opened this issue Jun 3, 2019 · 4 comments
Closed

[Bug] Forward and back button don't have visually disabled state in Dark Theme #3087

Scripterr opened this issue Jun 3, 2019 · 4 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint
Milestone
Sprint 6-1 (Stabi...

Comments

@Scripterr
Copy link

Scripterr commented Jun 3, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

1.Open a page from search bar.
2.Click on the menu icon.

Expected behavior

The menu do have a visually disabled state of forward and back button.

Actual behavior

The menu don't have a visually disabled state of forward and back button

Device information

  • Android device: 8.0.0
  • Fenix version: 1.0.1922 (Build #11530617 68.0-20190527103257)

┆Issue is synchronized with this Jira Task
@Scripterr Scripterr added the 🐞 bug Crashes, Something isn't working, .. label Jun 3, 2019
@ekager
Copy link
Contributor

ekager commented Jun 3, 2019

In a specific theme? Dark, light, private? Or all themes?

@Scripterr
Copy link
Author

In a specific theme? Dark, light, private? Or all themes?

I'm using dark mode and I just have checked it's working well in light mode.

@ekager ekager changed the title [Bug] Forward and back button don't have visually disabled state [Bug] Forward and back button don't have visually disabled state in Dark Theme Jun 3, 2019
@uniquePWD
Copy link

Unfortunately, the problem also exhibits in private tabs.

@bifleming bifleming added the Release Blocker Blocks a Release label Jun 4, 2019
@vesta0 vesta0 added P1 Current sprint and removed Release Blocker Blocks a Release labels Jun 4, 2019
@ekager ekager self-assigned this Jun 5, 2019
ekager added a commit to ekager/fenix that referenced this issue Jun 5, 2019
@ekager
For mozilla-mobile#3087 - Adds disabled color attr
1311fec
colintheshots pushed a commit that referenced this issue Jun 6, 2019
@ekager @colintheshots
For #3087 - Adds disabled color attr (#3192)
9624964 
* For #3087 - Adds disabled color attr

* Change alpha to 40%
@ekager ekager added the eng:qa:needed QA Needed label Jun 11, 2019
@LaurentiuApahideanSV
Copy link

I have verified the issue on a Samsung Galaxy Tab A (Android 7.0) and OnePlus 6T (Android 9) using the latest Firefox Preview 1.0.1924 (Build #11650657) 6/14 and the issue no longer occurs.

@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 14, 2019
@ekager ekager closed this as completed Jun 14, 2019
@data-sync-user data-sync-user changed the title [Bug] Forward and back button don't have visually disabled state in Dark Theme FNX3-16779 ⁃ [Bug] Forward and back button don't have visually disabled state in Dark Theme Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16779 ⁃ [Bug] Forward and back button don't have visually disabled state in Dark Theme [Bug] Forward and back button don't have visually disabled state in Dark Theme May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint
Projects
None yet
Milestone
Sprint 6-1 (Stability & Quality)
Development

No branches or pull requests
8 participants
@uniquePWD @ekager @Scripterr @vesta0 @abodea @bifleming @LaurentiuApahideanSV @data-sync-user