Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[META] App-Links: handle intent #3177

Closed
2 tasks done
vesta0 opened this issue Jun 5, 2019 · 23 comments
Closed
2 tasks done

[META] App-Links: handle intent #3177

vesta0 opened this issue Jun 5, 2019 · 23 comments
Assignees
Labels
Feature:OpenInApp intents needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Jun 5, 2019

User Problem

-User taps on a "download/get this app" link on a site.
-They are taken to the Google Play Store mobile site within Fenix with no "open in app" option to open Google Play Store native app
-As a result, user will first need to sign into their Google account.
-If they have the app installed, they will see an "installed" button but still no "open in app" option (although the "open in app" option often shows up if user taps on the "installed" button once)
-If they don't have the app installed, they have to tap on "install", choose which device they want to install the app to, and still not have an "open app" option after installation has been completed.

*Fennec surfaces the "open in app" badge allowing user to open the Google Play Store App but it's not perfect/consistent either. We should support better integration with Android system overall. This is important for browser usability.

User Stories:

Dependencies

UX Spec

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added the P1 Current sprint label Jun 5, 2019
@vesta0 vesta0 added this to the Fenix 1.1 Backlog milestone Jun 5, 2019
@vesta0 vesta0 added the needs:ac Needs Android Component Work label Jun 5, 2019
@sv-ohorvath
Copy link
Contributor

Check the test links on this page: https://simonmarquis.github.io/Android-App-Linking/
No app installed - they should redirect to the playstore page.
When the AppLinks app is installed, they should open the link in the app.

@vesta0 vesta0 changed the title Android app link intent GPS app link intent Jun 6, 2019
@vesta0 vesta0 added this to 🐉 Fenix Backlog in A-C: Android Components Sprint Planning Jun 10, 2019
@jhugman
Copy link
Contributor

jhugman commented Jun 12, 2019

This is implemented as part of ac#3058.

The GetAppLinkRedirect use case has a includeInstallAppFallback flag in its constructor.

Blocked by #3358 .

@vesta0 vesta0 removed P1 Current sprint labels Jun 21, 2019
@AaronMT
Copy link
Contributor

AaronMT commented Jun 26, 2019

I imagine this is the same scenario, correct?

E.g, I visit Pinterest.com, I see the 'Get on Google Play' at the bottom of their sign-in. Tapping it does nothing currently (52850fe).

@ekager
Copy link
Contributor

ekager commented Jun 26, 2019

Yes @AaronMT , once we reenable the app links feature, that should work

@vesta0 vesta0 added the must label Jul 2, 2019
@vesta0 vesta0 removed this from 🐉 Fenix Backlog in A-C: Android Components Sprint Planning Jul 2, 2019
@vesta0 vesta0 changed the title GPS app link intent Handle Play Store link Intent Jul 5, 2019
@vesta0 vesta0 removed this from Must in Fenix Q3 Feature Backlog Jul 5, 2019
@jhugman jhugman moved this from Backlog to Stories in A-C: Android Intent URLs Jul 8, 2019
@jhugman jhugman moved this from Stories to Backlog in A-C: Android Intent URLs Jul 12, 2019
@jhugman jhugman changed the title Handle Play Store link Intent App-Links: handle intent:// with fallback to install the app. Jul 12, 2019
@jhugman
Copy link
Contributor

jhugman commented Jul 12, 2019

I visit Pinterest.com, I see the 'Get on Google Play' at the bottom of their sign-in. Tapping it does nothing currently (52850fe).

Where the page is directing the user directly to Google Play, this will be handled by a market:// link – which is enabled by ac#3725.

This is blocked by ac#3687.

@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@liuche liuche added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label May 7, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint Backlog in Fenix Sprint Kanban May 7, 2020
@vesta0 vesta0 removed this from Sprint Backlog in Fenix Sprint Kanban May 7, 2020
@vesta0 vesta0 added this to Backlog in Fenix: GeckoView via automation May 12, 2020
@vesta0 vesta0 moved this from Backlog to High Priority in Fenix: GeckoView May 12, 2020
@vesta0 vesta0 added this to Q2: A-C, Sync, GV, Perf in Fenix Product Backlog May 12, 2020
@vesta0
Copy link
Collaborator Author

vesta0 commented May 21, 2020

@rocketsroger what's the word on the GV regression?

@rocketsroger
Copy link
Contributor

rocketsroger commented May 21, 2020

@rocketsroger what's the word on the GV regression?

The GV regression was fixed. But the fix introduced a new API that A-C will have to hook into for it to work. I've put up a change to hook into the new API. mozilla-mobile/android-components#7047.

@fluffyemily fluffyemily moved this from High Priority to In GV Nightly in Fenix: GeckoView Jun 2, 2020
@vesta0
Copy link
Collaborator Author

vesta0 commented Jun 2, 2020

@rocketsroger can we close this now?

@rocketsroger
Copy link
Contributor

@rocketsroger can we close this now?

Yes, I think so. I don't know any open issues related to this.

@vesta0 vesta0 closed this as completed Jun 3, 2020
Fenix Q1 Feature Backlog automation moved this from Must to Completed Jun 3, 2020
@data-sync-user data-sync-user changed the title [META] App-Links: handle intent FNX3-16837 ⁃ [META] App-Links: handle intent Aug 11, 2020
Fenix: GeckoView automation moved this from In GV Nightly to Triage Aug 11, 2020
@vesta0 vesta0 closed this as completed Aug 19, 2020
@amedyne amedyne moved this from Triage to Done in Fenix: GeckoView Sep 1, 2020
@vesta0 vesta0 moved this from Important bugs to Q2: Individual User Stories in Fenix Product Backlog Sep 10, 2020
@karlcow
Copy link

karlcow commented Aug 4, 2021

@vesta0 This still seems to happen for a number of users. see the recent web-bugs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature:OpenInApp intents needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
Development

No branches or pull requests