Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Not all share intents find Fenix #319

Closed
jonalmeida opened this issue Jan 30, 2019 · 3 comments
Closed

Not all share intents find Fenix #319

jonalmeida opened this issue Jan 30, 2019 · 3 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, ..
Milestone

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jan 30, 2019

Steps to reproduce

  1. Open YT and click a link in a video description

Expected behavior

  • (if you have mulitple browser apps) The menu of apps should include r-b.

Actual behavior

  • The browser isn't on the list at all.

Device information

  • Android device: Android 9 (Pixel 2)
  • Reference Browser version: 1.0.1905 (Build #10301403 🦎 66.0a1-20190128092811)

See mozilla-mobile/reference-browser#526

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added the 🐞 bug Crashes, Something isn't working, .. label Jan 30, 2019
@jonalmeida jonalmeida self-assigned this Jan 30, 2019
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Jan 30, 2019
@ghost ghost added in progress labels Jan 30, 2019
@ghost ghost removed in progress labels Jan 30, 2019
@pocmo pocmo added this to the Sprint 2 (M1) milestone Jan 31, 2019
@colintheshots
Copy link
Contributor

Google Maps still cannot share to Fenix, among others.

@colintheshots colintheshots reopened this Feb 1, 2019
@jonalmeida
Copy link
Contributor Author

That's because Google Maps gives us more than just a link we can handle.

For share intents with: "X person wants you to join them: https://example.com"
We don't handle this because we would need to parse out the URL which has it's issues.

I'm going to close this since we handle the cases we set out to do. We can file a follow up for investigating how we want to handle intents with mixed data.

@pocmo
Copy link
Contributor

pocmo commented Feb 1, 2019

For share intents with: "X person wants you to join them: https://example.com"
We don't handle this because we would need to parse out the URL which has it's issues.

IntentProcessor does either open a URL or performs a search for text.

That said.. we do have WebURLFinder in support-utils which can find URLs in text too. And we use that to find URLs in the clipboard. Maybe we could add that to the IntentProcessor too?

@data-sync-user data-sync-user changed the title Not all share intents find Fenix FNX3-16844 ⁃ Not all share intents find Fenix Aug 11, 2020
@pocmo pocmo closed this as completed Aug 13, 2020
@data-sync-user data-sync-user changed the title FNX3-16844 ⁃ Not all share intents find Fenix Not all share intents find Fenix May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Development

No branches or pull requests

4 participants