[Bug][a11y] Share and 3dots menu button from Collections are not correctly pronounced using Talkback

[sv-sdeiac]

Prerequisites

1. You have a collection saved.
2. You have Talkback option enabled from your Android settings.

Steps to reproduce

1. Open Firefox preview;
2. Tap on the share button or 3dots menu button from the Collections menu;

Expected behavior

The share and 3dots menu button are correctly pronounced.

Actual behavior

The share and 3dots menu button are not pronounced correctly. The Talkback read: 'Tab menu button' on both of the buttons.

Device information

• Android device: LG G7fit (Android 8.1).
• Fenix version: 1.0.1924.

┆Issue is synchronized with this Jira Task

[ekager]

We will need new strings for this, but this is bad accessibility. @vesta0 can we prioritize this post MVP.

[vesta0]

Agreed @ekager we will address this in our next sprint.

[mauryat]

@sblatz , I'd like to work on this.

[sblatz]

@mauryat Go for it! 😄

[mauryat]

Thanks!

…

On Thu, Jul 11, 2019, 9:22 PM Sawyer Blatz ***@***.***> wrote: @mauryat <https://github.com/mauryat> Go for it! 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3419?email_source=notifications&email_token=ACL5E2EK2XHAEMO6ZXDCSW3P65JKDA5CNFSM4HXZGHU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXERSA#issuecomment-510544072>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACL5E2CFOZBXL3NWGSM66O3P65JKDANCNFSM4HXZGHUQ> .

[mheubusch]

Strings: For share icon use "Share button" and for 3-dot button in a collection only, use "Collection menu button" Note also per bug #725 that there is also talkback for the collection itself and this should be "" <If 1 URL saved to collection: "Saved: [<title> of most recently saved page]"
If 2 URLs saved to collection: "Saved: [<title> of most recently saved page] and [<title> of second most recently saved page]"
If 3 or more URLs saved to collection: "Saved: [<title> of most recently saved page] and [number of additional tabs in collection] more tabs"

[sv-sdeiac]

Verified as fixed on Firefox Preview 1.2.0-rc.2 using Nexus 9 (Android 7.1.1) and LG G7fit (Android 8.1).