Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Selected tab in a scrolling list, for a new collection, has no checkbox #3433

Closed
sv-ohorvath opened this issue Jun 13, 2019 · 2 comments
Closed

[Bug] Selected tab in a scrolling list, for a new collection, has no checkbox #3433

sv-ohorvath opened this issue Jun 13, 2019 · 2 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint
Milestone
Sprint 6-1 (Stabi...

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jun 13, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open multiple tabs, to have a scrollable list.
  2. Tap save to collection.
  3. Select the top tab, scroll, select other tabs, tap Save.
    1. Expected behavior
      All selected tabs have a thicked checkbox.
    2. Actual behavior
      On the name collection screen, the first tab selected (before scrolling down) doesn't have a checkbox.
    3. Device information
  • Android device: Nexus 5 (Android 6.0.1), Note 8 (Android 9)
  • Fenix version: 6/13.

┆Issue is synchronized with this Jira Task
@sv-ohorvath sv-ohorvath added the 🐞 bug Crashes, Something isn't working, .. label Jun 13, 2019
@sv-ohorvath sv-ohorvath mentioned this issue Jun 13, 2019
Closed
@ekager
Copy link
Contributor

ekager commented Jun 13, 2019 •
edited
Loading

Edited:
Ah I see the problem. If you have a long list of tabs, check the top one, go to create new collection, and then press back to the list of tabs, the top one that was checked will lose its checkbox

@ekager ekager self-assigned this Jun 13, 2019
ekager added a commit to ekager/fenix that referenced this issue Jun 13, 2019
@ekager
For mozilla-mobile#3433 - Add checkbox hide changes to change payload
0ca95fa
@vesta0 vesta0 added the P1 Current sprint label Jun 13, 2019
ekager added a commit that referenced this issue Jun 13, 2019
@ekager
For #3433 - Add checkbox hide changes to change payload
8b4c2db
@ekager ekager added the eng:qa:needed QA Needed label Jun 13, 2019
@project-bot project-bot bot added this to Ready for QA in Fenix Sprint Kanban Jun 13, 2019
@lobontiumira
Copy link

Verified as fixed on the latest build 1.0.1924 (#11650657), with Samsung Galaxy Note 8 (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 14, 2019
@lobontiumira lobontiumira moved this from Ready for QA to Done in Fenix Sprint Kanban Jun 14, 2019
@data-sync-user data-sync-user changed the title [Bug] Selected tab in a scrolling list, for a new collection, has no checkbox FNX3-17014 ⁃ [Bug] Selected tab in a scrolling list, for a new collection, has no checkbox Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-17014 ⁃ [Bug] Selected tab in a scrolling list, for a new collection, has no checkbox [Bug] Selected tab in a scrolling list, for a new collection, has no checkbox May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified P1 Current sprint
Projects
None yet
Milestone
Sprint 6-1 (Stability & Quality)
Development

No branches or pull requests
6 participants
@NotWoods @sv-ohorvath @ekager @lobontiumira @vesta0 @data-sync-user