Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Tab sent snackbar missing #3478

Closed
ryanfeeley opened this issue Jun 14, 2019 · 5 comments
Closed

Tab sent snackbar missing #3478

ryanfeeley opened this issue Jun 14, 2019 · 5 comments
Assignees
@ekager
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:SendTab
Projects
A-C: Meta: Send Tab Components
Milestone
v1.1

Comments

@ryanfeeley
Copy link

ryanfeeley commented Jun 14, 2019 •
edited by data-sync-user
Loading

When users send a tab from Fenix to another device, there should be this snackbar appearing. It was not showing during the most recent Sync Fest.

┆Issue is synchronized with this Jira Task
@ekager
Copy link
Contributor

ekager commented Jun 14, 2019

Will be simple to add but requires string work so I won't be able to get it in today before cutting MVP :/

@ryanfeeley
Copy link
Author

@ekager If possible, you can use the equivalent string from desktop which is Sent! https://transvision.mozfr.org/string/?entity=browser/chrome/browser/browser.properties:confirmationHint.sendToDevice.label&repo=gecko_strings

ekager added a commit to ekager/fenix that referenced this issue Jun 15, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
91f06e1 
…ce sharing
ekager added a commit to ekager/fenix that referenced this issue Jul 1, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
8008b4b 
…ce sharing
ekager added a commit to ekager/fenix that referenced this issue Jul 1, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
474ed48 
…ce sharing
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
39b2f75 
…ce sharing
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
eda26ef 
…ce sharing
@vesta0
Copy link
Collaborator

vesta0 commented Jul 9, 2019

Adding this to the send tab board

@vesta0 vesta0 added this to the Q3 Feature Backlog milestone Jul 9, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 9, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
17c2b67 
…ce sharing
@vesta0 vesta0 added the eng:ready Ready for engineering label Jul 9, 2019
@ekager ekager self-assigned this Jul 9, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 9, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
493ddce 
…ce sharing
ekager added a commit to ekager/fenix that referenced this issue Jul 9, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
095104e 
…ce sharing
ekager added a commit to ekager/fenix that referenced this issue Jul 10, 2019
@ekager
For mozilla-mobile#3478 - Add Tab sent snackbar confirmation for devi…
ce8b7f0 
…ce sharing
ekager added a commit that referenced this issue Jul 10, 2019
@ekager
For #3478 - Add Tab sent snackbar confirmation for device sharing
21c75ca
@ekager ekager added the eng:qa:needed QA Needed label Jul 10, 2019
@liuche liuche added Strings Ready and removed needs:strings Needs strings labels Jul 10, 2019
@vesta0 vesta0 added this to Ready for QA in Fenix Sprint Kanban Jul 11, 2019
@lobontiumira
Copy link

Verified that the "Tab sent!" snackbar is displayed on the debug build 1.0.1928 GV 68.0-20190612114833, but on Motorola Nexus 6 (Android 7.1.1) is overlapping the URL bar:

Screenshot_20190711-151758

@ryanfeeley should I file a new issue for this reason?
Thank you!

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 11, 2019
@lobontiumira lobontiumira added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 11, 2019
@ekager
Copy link
Contributor

ekager commented Jul 11, 2019

Yeah let's close this and I will file a new issue, thanks!

@ekager ekager closed this as completed Jul 11, 2019
A-C: Meta: Send Tab Components automation moved this from In Progress to Done Jul 11, 2019
Fenix Q3 Feature Backlog automation moved this from Must to Done! Jul 11, 2019
@lobontiumira lobontiumira removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 12, 2019
@lobontiumira lobontiumira moved this from Ready for QA to Done in Fenix Sprint Kanban Jul 12, 2019
@colintheshots colintheshots modified the milestones: 1.1 Backlog, v1.1 Jul 23, 2019
@vesta0 vesta0 removed this from Done! in Fenix Q3 Feature Backlog Sep 2, 2019
@data-sync-user data-sync-user changed the title Tab sent snackbar missing FNX3-17044 ⁃ Tab sent snackbar missing Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-17044 ⁃ Tab sent snackbar missing Tab sent snackbar missing May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:SendTab
Projects
No open projects
A-C: Meta: Send Tab Components
  
Done
Milestone
v1.1
Development

No branches or pull requests
8 participants
@ryanfeeley @colintheshots @liuche @NotWoods @ekager @lobontiumira @vesta0 @data-sync-user