Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Find my downloaded files in the browser #349

Closed
5 tasks
boek opened this issue Feb 1, 2019 · 19 comments
Closed
5 tasks

Find my downloaded files in the browser #349

boek opened this issue Feb 1, 2019 · 19 comments
Assignees
Labels
eng:qa:verified QA Verified Feature:Download feature request 🌟 New functionality and improvements

Comments

@boek
Copy link
Contributor

boek commented Feb 1, 2019

Part of Meta: #4417

User Story

As a user, I want to be able to easily and quickly find and access my downloaded files from within the browser, so I don’t have to look for them in my Android file system.

Requirements

Populate the downloads UI with a list of files that have been downloaded

(for the v1 minimum, let's copy what fennec does)

Acceptance Criteria

  • I can navigate to the Downloads section in my browser
  • I can view the list of my COMPLETED downloaded files in the browser
  • There is a cap on how long we display a download
  • If user deletes a downloaded file from the file system, I no longer see the download in the browser
  • I can tap on a downloaded file and open it using the supported Android system app

┆Issue is synchronized with this Jira Task

@boek boek added the size S label Feb 1, 2019
@boek boek added this to the Milestone 2 Backlog milestone Feb 1, 2019
@bbinto bbinto modified the milestones: Milestone 2 Backlog, Backlog Feb 1, 2019
@vesta0 vesta0 modified the milestones: Backlog, Backlog (After MVP) Mar 27, 2019
@vesta0 vesta0 added P2 Upcoming release Feature:Download Feature:Library and removed size S P2 Upcoming release labels Mar 27, 2019
@vesta0 vesta0 added the feature request 🌟 New functionality and improvements label Jul 26, 2019
@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@vesta0 vesta0 removed the P2 Upcoming release label Jul 31, 2019
@vesta0 vesta0 removed the feature request 🌟 New functionality and improvements label Aug 27, 2019
@vesta0 vesta0 changed the title Create the downloads UI Downloads UI Aug 27, 2019
@vesta0 vesta0 changed the title Downloads UI View downloads Aug 27, 2019
@nahuhh
Copy link

nahuhh commented Sep 6, 2019

To add to this request

  • a ui for the downloader (within menu > library) where you can view current and past downloads, along with the ability to pause/resume/cancel ones that are in progress

@djc
Copy link

djc commented Sep 24, 2019

As a quick fix, even a menu item that sends me to the Files app would be an improvement over the current situation, where downloads basically completely disappear after the initial notification.

@sblatz sblatz added the feature request 🌟 New functionality and improvements label Sep 24, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 24, 2019

Closing in favor of #4417.

@sblatz sblatz closed this as completed Sep 24, 2019
@vesta0 vesta0 reopened this Oct 3, 2019
@vesta0 vesta0 added must and removed feature request 🌟 New functionality and improvements labels Oct 3, 2019
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 12, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 12, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 12, 2020
@liuche
Copy link
Contributor

liuche commented Aug 12, 2020

UX will provide icons by next Wednesday, but in the meantime, we can do the default icons. We want to ship with the final icons though.

@liuche liuche changed the title FNX3-17054 ⁃ [UX] Find my downloaded files in the browser Find my downloaded files in the browser Aug 12, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 13, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 13, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 13, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 18, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Aug 18, 2020
kglazko pushed a commit that referenced this issue Aug 19, 2020
@kglazko kglazko added the eng:qa:needed QA Needed label Aug 19, 2020
@kglazko
Copy link
Contributor

kglazko commented Aug 19, 2020

This was merged with Nightly feature flags and a QA-needed label has been added.

@liuche
Copy link
Contributor

liuche commented Aug 19, 2020

For QA: the downloads won't persist until this AC issue has landed: mozilla-mobile/android-components#7762

@sflorean
Copy link
Contributor

sflorean commented Aug 20, 2020

Testing results on Nightly 8/20:

cc @kglazko

@sflorean sflorean removed the eng:qa:needed QA Needed label Aug 20, 2020
@liuche liuche added this to Inbox in Engineering triage via automation Aug 28, 2020
@liuche liuche moved this from Inbox to Uplifts for Firefox Beta 80 in Engineering triage Aug 28, 2020
@Amejia481
Copy link
Contributor

For testing this feature:

You will be able to :

  1. Navigate to the Downloads section.
  2. View the list of my COMPLETED downloaded files.
  3. Tap on a downloaded file and open it using the supported Android system app.
  4. Downloaded files should be persistent even after the application gets restarted.

To test that 4 (downloads are persistent), after downloaded a file, close the app using the task manager and re open the app, then go to the three dots menu -> Downloads and downloaded files should be shown.

@liuche liuche added the eng:qa:needed QA Needed label Sep 1, 2020
@liuche
Copy link
Contributor

liuche commented Sep 1, 2020

"If user deletes a downloaded file from the file system, I no longer see the download in the browser" is not implemented yet, and will not be present in this build.

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Sep 2, 2020

"If user deletes a downloaded file from the file system, I no longer see the download in the browser" is not implemented yet, and will not be present in this build.

Verified as fixed on Beta 81.1.0 based on the acceptance criteria from #349 (comment), including this: the files deleted from the system file manager will be removed from the browser Downloads list as well (fixed in #13979).

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 2, 2020
@liuche liuche removed this from Uplifts for Firefox Beta 81 in Engineering triage Sep 8, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Sep 30, 2020
kglazko pushed a commit to kglazko/fenix that referenced this issue Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified Feature:Download feature request 🌟 New functionality and improvements
Projects
None yet
Development

No branches or pull requests